Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle invalid input in TimeFieldMinMax, resolve missing CSS reference, and remove classnames #110

Closed
wants to merge 4 commits into from

Commits on Nov 29, 2024

  1. fix: Handle invalid input in TimeField and resolve missing CSS reference

    - Added input validation for TimeField to handle invalid time entries
    - Updated `onModify` logic to validate and parse user input before
    setting the value.
    - Disabled the confirm button for invalid inputs
    - Removed missing CSS file reference (`timeFieldMinMaxView.css`)
    laurenic0l committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    dda24b6 View commit details
    Browse the repository at this point in the history
  2. fix: removed class name

    laurenic0l committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    4eca806 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. fix: update TimeFieldMinMaxView to improve validation and feedback

    - Added validation to ensure the Confirm button is only enabled for
    valid, non-empty time inputs.
    - Updated toast message to confirm the action
    laurenic0l committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    5759035 View commit details
    Browse the repository at this point in the history
  2. fix: replace onModify with onValueChange

    - Updated the `TimeFieldMinMaxView` class to use `onValueChange` instead
    of `onModify`.
    laurenic0l committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    2b14eff View commit details
    Browse the repository at this point in the history