fix: Handle invalid input in TimeFieldMinMax, resolve missing CSS reference, and remove classnames #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added input validation for TimeField to handle invalid time entries - Updated `onModify` logic to validate and parse user input before setting the value. - Disabled the confirm button for invalid inputs - Removed missing CSS file reference (`timeFieldMinMaxView.css`)
laurenic0l
changed the title
hyyan
requested changes
Nov 29, 2024
| } | ||
| App.console().log(meeting.getValue() + ""); | ||
| }); | ||
| .onModify(e -> { |
There was a problem hiding this comment.
Use onValueChange and the get the value from the event's payload
| confirm.setEnabled(true); | ||
| } catch (Exception ex) { | ||
| confirm.setEnabled(false); | ||
| App.console().log("Invalid time input: " + e.getText()); |
| @@ -14,7 +13,6 @@ | |||
|
|
|||
| import java.time.LocalTime; | |||
|
|
|||
| @InlineStyleSheet("context://css/fields/timefield/timeFieldMinMaxView.css") | |||
| @Route | |||
| @FrameTitle("Time Field Min/Max") | |||
| public class TimeFieldMinMaxView extends Composite<FlexLayout> { | |||
There was a problem hiding this comment.
Do something useful with the confirm button. A toast ?!
There was a problem hiding this comment.
Implemented a toast to confirm the action
- Added validation to ensure the Confirm button is only enabled for valid, non-empty time inputs. - Updated toast message to confirm the action
- Updated the `TimeFieldMinMaxView` class to use `onValueChange` instead of `onModify`.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onModifylogic to validate and parse user input before setting the value.timeFieldMinMaxView.css)closes #106 and closes #105