Code

Armament refactor update#33

Code

Open

warp-core wants to merge 35 commits intomasterwarp-core/endless-sky:masterfrom Armament-refactor-updatewarp-core/endless-sky:Armament-refactor-updateCopy head branch name to clipboard

+384-130

Commits

Commits on Apr 4, 2024

• Add 'WeaponIndex' to Ship

  Show description for fc4b7ca
  

  mike-f1

  authored and

  warp-core

  committed
  fc4b7ca

• Prepare different kind of collections to iterate on

  

  mike-f1

  authored and

  warp-core

  committed
  5a00413

• Move added special members in 'Armament'

  

  mike-f1

  authored and

  warp-core

  committed
  0b2eeb1

• Simplify a bit fighter docking code

  

  mike-f1

  authored and

  warp-core

  committed
  fc7fc67

• Make 'views' of fixed and turretted weapons a member

  Show description for ea82c95
  

  mike-f1

  authored and

  warp-core

  committed
  ea82c95

• Do not collect empty hardpoints on 'views'

  Show description for cc243cb
  

  mike-f1

  authored and

  warp-core

  committed
  cc243cb

• Rewrite a loop to use the new 'views'

  

  mike-f1

  authored and

  warp-core

  committed
  599c68b

• Rewrite a loop using a new member of Armament

  Show description for 391396a
  

  mike-f1

  authored and

  warp-core

  committed
  391396a

• Use everywhere the same variable name

  

  mike-f1

  authored and

  warp-core

  committed
  0357219

• Cache ranges of weapons in Armament

  Show description for 09c3580
  

  mike-f1

  authored and

  warp-core

  committed
  09c3580

• Cache maximum range of turrets

  

  mike-f1

  authored and

  warp-core

  committed
  874853a

• Use an additional collection to speed up 'Ship::FireAntiMissile'

  

  mike-f1

  authored and

  warp-core

  committed
  5fa9435

• Use an(other) collection to speed up AI

  

  mike-f1

  authored and

  warp-core

  committed
  98d4b05

• Fix the forth caregory to 'all weapons but not anti missile'

  

  mike-f1

  authored and

  warp-core

  committed
  4a46a4f

• Make a new free function 'ShouldDockForReloading'

  

  mike-f1

  authored and

  warp-core

  committed
  29abbca

• Address review note for a 'misleading' name

  

  mike-f1

  authored and

  warp-core

  committed
  6424eb5

• Address review style issue

  

  mike-f1

  authored and

  warp-core

  committed
  9bbefd7

• Change name of 'all weapons excluding anti missile' method

  

  mike-f1

  authored and

  warp-core

  committed
  39a1407

• Removed 'CalculateRanges()' method.

  Show description for 255df53
  

  mike-f1

  authored and

  warp-core

  committed
  255df53

• Changed misleading names

  Show description for e4c17a4
  

  mike-f1

  authored and

  warp-core

  committed
  e4c17a4

• if( ...I have did it...

  

  mike-f1

  authored and

  warp-core

  committed
  bd26d94

• Don't copy things thousand a frame...

  

  mike-f1

  authored and

  warp-core

  committed
  9fbc5f0

• no 'std::' except std::move

  

  mike-f1

  authored and

  warp-core

  committed
  4d5290f

• Implement "Rule of 5"

  

  mike-f1

  authored and

  warp-core

  committed
  1f7815c

• Add a couple of overloads in Armament

  Show description for dcef0b6
  

  mike-f1

  authored and

  warp-core

  committed
  dcef0b6

• Wrap long lines

  

  mike-f1

  authored and

  warp-core

  committed
  6df2010

• 3 lines between methods

  

  mike-f1

  authored and

  warp-core

  committed
  5f6a6d3

• Cache the Hardpoint

  Show description for 89458de
  

  mike-f1

  authored and

  warp-core

  committed
  89458de

• Fixes

  warp-core

  committed
  299d1bf

• Revert "fix(content): Remove duplicate Korath phrase (endless-sky#9962)"

  Show description for 9511637
  warp-core

  committed
  9511637

Commits on Apr 5, 2024

• Style and stuff

  warp-core

  committed
  5730eb4

• Restore FireTractorBeam

  warp-core

  committed
  10f3744

• Remove unused method

  warp-core

  committed
  4accbf4

• Update Armament.cpp

  warp-core

  committed
  a262ddc

• Update Armament.cpp

  warp-core

  committed
  9ac48fe