Armament refactor update #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allow any weapon be "indexed" without doing it externally.
...saving memory allocations but defining ctor and copy ctor of Armament because the views must be recreated on copy.
...and discard 'const' requirement of 'Hardpoint' views so we can 'Step' and 'Aim' only on those actually used.
Let Armament be able to calculate their minimum and maximum guns range.
Saving an expensive loop in the middle of doing something else.
Replaced with a couple of free funtion which are easier to understand and do not need to be class members.
An 'Hardpoint' can be empty, so making that part of "views" names may cause doubts; perhaps replacing that part of the name with 'Weapons' (as done in methods) should helps.
...so it can accept an Hardpoint as argument.
Writing 'hardpoints[index]' is (more or less) like calling a complete function each time: this should help compiler spot the not-so-obvious optimization of using the result of that call in-lieu of calling the very same function multiple times.
This reverts commit 810a8d5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.