-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WebRTC-specific interactions with capture/receive/RTP timestamps #224
Open
handellm
wants to merge
3
commits into
w3c:main
Choose a base branch
from
handellm:timestamps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -72,6 +72,19 @@ <h2>Terminology</h2> | |||||
<p> | ||||||
The process of <dfn data-lt="free|freed|freeing">freeing</dfn> a candidate is defined in [[RFC8445]] Section 8.3. | ||||||
</p> | ||||||
|
||||||
<p> | ||||||
<!-- TODO: use the xref mechanism when mediacapture-extensions spec status is cleared up. | ||||||
See https://github.com/w3c/mediacapture-extensions/issues/132 --> | ||||||
The following terms are defined in <a href="https://w3c.github.io/mediacapture-extensions">mediacapture-extensions</a> | ||||||
<a href="https://w3c.github.io/mediacapture-extensions/#video-timestamp-concepts/">video timestamp concepts</a> | ||||||
</p> | ||||||
<ul> | ||||||
<li><dfn>presentation timestamp</dfn></li> | ||||||
<li><dfn>capture timestamp</dfn></li> | ||||||
<li><dfn>receive timestamp</dfn></li> | ||||||
<li><dfn>RTP timestamp</dfn></li> | ||||||
</ul> | ||||||
</section> | ||||||
<section id="ice-csp"> | ||||||
<h3> | ||||||
|
@@ -1540,6 +1553,46 @@ <h2>Event summary</h2> | |||||
</tbody> | ||||||
</table> | ||||||
</section> | ||||||
<section class="informative"> | ||||||
<h2>Timestamp behavior</h2> | ||||||
<h2>RTCRtpSender timestamp effects on packet NTP and RTP timestamps</h2> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
there is nothing in the spec that says that incoming RTP is coming from an RTPSender. |
||||||
<p> | ||||||
The user agent defines a <dfn class="export">frame timestamp</dfn> being the same as the [=capture timestamp=] | ||||||
of the frame being produced on the {{RTCRtpSender}} {{MediaStreamTrack}} if it is set. | ||||||
If it is unset the user agent estimates a timestamp from the sent frame's [=presentation timestamp=] together with the | ||||||
time it was received by the {{RTCRtpSender}}. | ||||||
</p> | ||||||
<p> | ||||||
The NTP and RTP timestamps of the encoded frame corresponding to the frame being produced on the {{RTCRtpSender}} | ||||||
{{MediaStreamTrack}} are sourced from the [=frame timestamp=]. | ||||||
</p> | ||||||
<p> | ||||||
The [=RTP timestamp=] of frames being produced on the {{RTCRtpSender}} is ignored. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
</p> | ||||||
<h2>RTCRtpReceiver timestamps</h2> | ||||||
<h3>Remote capture timestamp</h3> | ||||||
<p> | ||||||
<!-- TODO: How this is estimated is under specified and should be fixed, but the section holds the requestVideoFrameCallback text for now --> | ||||||
For a frame produced in a {{RTCRtpReceiver}} track, the user agent computes a | ||||||
<dfn class="export">remote capture timestamp</dfn>. It is a best-effort estimate of the local capture | ||||||
time on the sender translated to the receiver clock, and can use methods like using RTCP SR | ||||||
as specified in [[?RFC3550]] Section 6.4.1, or by other alternative means if use by RTCP SR | ||||||
isn't feasible. | ||||||
</p><p> | ||||||
Each frame's [=capture timestamp=] is set to the [=remote capture timestamp=], if available. | ||||||
</p> | ||||||
<h3>Received RTP timestamp</h3> | ||||||
<p> | ||||||
For a frame produced in a {{RTCRtpReceiver}} track, the frame's [=RTP timestamp=] is set | ||||||
from the RTP timestamp of constituent packets of the corresponding received encoded frame. | ||||||
</p> | ||||||
<h3>Receive timestamp</h3> | ||||||
<p> | ||||||
For a frame produced in a {{RTCRtpReceiver}} track, the [=receive timestamp=] is set | ||||||
as the time the corresponding encoded frame was received by the platform, i.e. the time at which the | ||||||
last packet belonging to this frame was received over the network. | ||||||
</p> | ||||||
</section> | ||||||
<section class="informative" id="security-considerations"> | ||||||
<h2> | ||||||
Security Considerations | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to the unclear state of the mediacapture-extensions spec (not listed in browser-specs) I had to make some temporary reference structure as per below, when referring to concepts defined there.