Add WebRTC-specific interactions with capture/receive/RTP timestamps #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handellm
commented
Dec 19, 2024
| <p> | ||
| <!-- TODO: use the xref mechanism when mediacapture-extensions spec status is cleared up. | ||
| See https://github.com/w3c/mediacapture-extensions/issues/132 --> | ||
| The following terms are defined in <a href="https://w3c.github.io/mediacapture-extensions">mediacapture-extensions</a> |
There was a problem hiding this comment.
Due to the unclear state of the mediacapture-extensions spec (not listed in browser-specs) I had to make some temporary reference structure as per below, when referring to concepts defined there.
alvestrand
reviewed
Dec 19, 2024
| {{MediaStreamTrack}} are sourced from the [=frame timestamp=]. | ||
| </p> | ||
| <p> | ||
| The [=RTP timestamp=] of frames being produced on the {{RTCRtpSender}} is ignored. |
There was a problem hiding this comment.
Suggested change
| The [=RTP timestamp=] of frames being produced on the {{RTCRtpSender}} is ignored. | |
| The [=RTP timestamp=] of frames being produced on the {{RTCRtpSender}} is not visible in this API. |
alvestrand
reviewed
Dec 19, 2024
| @@ -1540,6 +1553,46 @@ <h2>Event summary</h2> | |||
| </tbody> | |||
| </table> | |||
| </section> | |||
| <section class="informative"> | |||
| <h2>Timestamp behavior</h2> | |||
| <h2>RTCRtpSender timestamp effects on packet NTP and RTP timestamps</h2> | |||
There was a problem hiding this comment.
Suggested change
| <h2>RTCRtpSender timestamp effects on packet NTP and RTP timestamps</h2> | |
| <h2>RTP timestamp effects on packet NTP and RTP timestamps</h2> |
there is nothing in the spec that says that incoming RTP is coming from an RTPSender.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the spec to describe how WebRTC interacts with timestamps added by w3c/mediacapture-extensions#156.
Related to changes needed by w3c/webcodecs#813
Preview | Diff