Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backgroundBlur to VideoFrameMetadata registry #841

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add backgroundBlur to VideoFrameMetadata registry #841

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4959d6f
Add backgroundBlur to VideoFrameMetadata registry
Oct 23, 2024
c8f5225
Fix typo
Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions video_frame_metadata_registry.src.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@
<td>segments</td>
<td>[Human face segmentation](https://w3c.github.io/mediacapture-extensions/#human-face-segmentation)</td>
</tr>
<tr>
<td>backgroundBlur</td>
<td>[Camera dffect status](https://github.com/markafoltz/camera-effects)</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we would like a link to a W3C document if possible.

Given it has interaction with https://w3c.github.io/mediacapture-main/#def-constraint-backgroundBlur, I would go with adding a section to https://w3c.github.io/mediacapture-extensions/.

And we would link this new section here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please merge this bit of spec somewhere normative.

Copy link
Member

@eladalon1983 eladalon1983 Oct 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/dffect/effect

</tr>
</table>


Expand Down