Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backgroundBlur to VideoFrameMetadata registry #841

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brychanrobot
Copy link

This adds the field that is being proposed in #839

@@ -61,6 +61,10 @@
<td>segments</td>
<td>[Human face segmentation](https://w3c.github.io/mediacapture-extensions/#human-face-segmentation)</td>
</tr>
<tr>
<td>backgroundBlur</td>
<td>[Camera dffect status](https://github.com/markafoltz/camera-effects)</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we would like a link to a W3C document if possible.

Given it has interaction with https://w3c.github.io/mediacapture-main/#def-constraint-backgroundBlur, I would go with adding a section to https://w3c.github.io/mediacapture-extensions/.

And we would link this new section here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please merge this bit of spec somewhere normative.

Copy link
Member

@eladalon1983 eladalon1983 Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/dffect/effect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants