Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create script to convert verification key points from BigInt to hex #2

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

jimmychu0807
Copy link
Contributor

This is an associated PR of semaphore-protocol/semaphore#875

Refer to the discussion at semaphore-protocol/semaphore#875 (comment)

cc @cedoor

@vplasencia
Copy link
Owner

Hey @jimmychu0807! It looks great. Thank you very much 🙏

Could you move the script to scripts instead of scripts/utils?

The scripts folder is for the scripts and the scripts/utils folder is for the utility functions that will be used in the scripts.

@jimmychu0807
Copy link
Contributor Author

@vplasencia updated.

@vplasencia vplasencia merged commit c5f5975 into vplasencia:main Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants