-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split SemaphoreVerifier key points into a separate library #875
Conversation
Split SemaphoreVerifier key points into a separate library
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jimmychu0807! Pointing to the main branch is ok 👍🏽
…or VerifierKeyPts lib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Semaphore Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Split SemaphoreVerifier key points into a separate library and transform all verification key points into one big bytes constant.
Also added a small script that convert decimal bigint to hex string.
Related Issue(s)
Closes #330
Related: #345
Other information
gas cost collected from
yarn test:report-gas
:Original:
With this PR:
@cedoor should I make a PR to semaphore
main
branch, or some other branch?cc @saleel
Checklist
yarn format
andyarn lint
without getting any errors