Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits to Manager Holocommands and Glowing Commands #1561

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

InsightfulParasite
Copy link
Collaborator

@InsightfulParasite InsightfulParasite commented Oct 20, 2023

About The Pull Request

Requested by kirie to combat darkness.
Added a limit to the amount of commands you can have at once.
Made a check for holo commands to look for a root instead of a typecache.
Made manager holocommands a root of temp_effect/HoloCommand
Moved all manager temp effects to temporary_visuals/miscallanious.dm

My main concern about making the manager commands glow is that if we ever make a abnormality that lives in darkness the effects can be actually effective in suppressing it. Which i guess isnt a bad thing.
Screenshot 2023-10-21 232911
Screenshot 2023-10-21 233059

Why It's Good For The Game

Combats darkness, allows manager to assist players in fighting watchman.

Changelog

🆑
tweak: edits holocommands and manager consoles handling of commands.
code: some edits to how commands are placed.
/:cl:

@InsightfulParasite InsightfulParasite added the Tweak A small change/addition to already existing systems. label Oct 21, 2023
@InsightfulParasite InsightfulParasite self-assigned this Oct 21, 2023
Copy link
Member

@EgorDinamit EgorDinamit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unacceptable.
Make effects themselves have light on them.

@InsightfulParasite InsightfulParasite force-pushed the manager-flare branch 5 times, most recently from 59fd542 to 67d2a55 Compare October 21, 2023 21:55
@InsightfulParasite InsightfulParasite changed the title Manager Holo Commands Now Glow Edits to Manager Holocommands and Glowing Commands Oct 21, 2023
@InsightfulParasite InsightfulParasite force-pushed the manager-flare branch 3 times, most recently from 8982d7c to ddea3b0 Compare October 22, 2023 03:32
@InsightfulParasite InsightfulParasite marked this pull request as ready for review October 22, 2023 03:33
@InsightfulParasite InsightfulParasite force-pushed the manager-flare branch 2 times, most recently from 17cbd57 to 51751e3 Compare October 23, 2023 00:36
@InsightfulParasite InsightfulParasite force-pushed the manager-flare branch 3 times, most recently from 4531dd6 to 30b64e1 Compare November 6, 2023 22:07
@InsightfulParasite InsightfulParasite force-pushed the manager-flare branch 4 times, most recently from a72719a to bac9cc4 Compare November 15, 2023 23:40
Update manager_camera.dm

Egors Suggestion

Manager Commands Now Glow

Update manager_camera.dm
@EgorDinamit EgorDinamit merged commit 4c64c1f into vlggms:master Dec 2, 2023
7 checks passed
@InsightfulParasite InsightfulParasite deleted the manager-flare branch December 6, 2023 05:55
vampirebat74 pushed a commit to vampirebat74/lobotomy-corp13 that referenced this pull request May 10, 2024
Manager Commands Now Glow

Update manager_camera.dm

Egors Suggestion

Manager Commands Now Glow

Update manager_camera.dm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tweak A small change/addition to already existing systems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants