-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edits to Manager Holocommands and Glowing Commands #1561
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InsightfulParasite
added
the
Tweak
A small change/addition to already existing systems.
label
Oct 21, 2023
InsightfulParasite
force-pushed
the
manager-flare
branch
from
October 21, 2023 03:52
05fbd11
to
807daa6
Compare
EgorDinamit
requested changes
Oct 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unacceptable.
Make effects themselves have light on them.
InsightfulParasite
force-pushed
the
manager-flare
branch
5 times, most recently
from
October 21, 2023 21:55
59fd542
to
67d2a55
Compare
InsightfulParasite
changed the title
Manager Holo Commands Now Glow
Edits to Manager Holocommands and Glowing Commands
Oct 21, 2023
InsightfulParasite
force-pushed
the
manager-flare
branch
3 times, most recently
from
October 22, 2023 03:32
8982d7c
to
ddea3b0
Compare
EgorDinamit
reviewed
Oct 22, 2023
EgorDinamit
reviewed
Oct 22, 2023
EgorDinamit
reviewed
Oct 22, 2023
InsightfulParasite
force-pushed
the
manager-flare
branch
2 times, most recently
from
October 23, 2023 00:36
17cbd57
to
51751e3
Compare
InsightfulParasite
force-pushed
the
manager-flare
branch
3 times, most recently
from
November 6, 2023 22:07
4531dd6
to
30b64e1
Compare
InsightfulParasite
force-pushed
the
manager-flare
branch
4 times, most recently
from
November 15, 2023 23:40
a72719a
to
bac9cc4
Compare
EgorDinamit
reviewed
Nov 18, 2023
InsightfulParasite
force-pushed
the
manager-flare
branch
from
November 18, 2023 23:26
ec2198c
to
aa31b01
Compare
EgorDinamit
reviewed
Nov 20, 2023
EgorDinamit
reviewed
Nov 20, 2023
InsightfulParasite
force-pushed
the
manager-flare
branch
from
November 20, 2023 23:08
aa31b01
to
adea2da
Compare
InsightfulParasite
force-pushed
the
manager-flare
branch
5 times, most recently
from
December 2, 2023 02:00
3d43e65
to
81ee29d
Compare
Update manager_camera.dm Egors Suggestion Manager Commands Now Glow Update manager_camera.dm
InsightfulParasite
force-pushed
the
manager-flare
branch
from
December 2, 2023 02:38
81ee29d
to
6da8234
Compare
EgorDinamit
approved these changes
Dec 2, 2023
vampirebat74
pushed a commit
to vampirebat74/lobotomy-corp13
that referenced
this pull request
May 10, 2024
Manager Commands Now Glow Update manager_camera.dm Egors Suggestion Manager Commands Now Glow Update manager_camera.dm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Requested by kirie to combat darkness.
Added a limit to the amount of commands you can have at once.
Made a check for holo commands to look for a root instead of a typecache.
Made manager holocommands a root of temp_effect/HoloCommand
Moved all manager temp effects to temporary_visuals/miscallanious.dm
My main concern about making the manager commands glow is that if we ever make a abnormality that lives in darkness the effects can be actually effective in suppressing it. Which i guess isnt a bad thing.
Why It's Good For The Game
Combats darkness, allows manager to assist players in fighting watchman.
Changelog
🆑
tweak: edits holocommands and manager consoles handling of commands.
code: some edits to how commands are placed.
/:cl: