-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update dev deps #240
Conversation
Looks like the testing update I made doesn't work in node 16. |
4e60c88
to
96ff8cc
Compare
What's the minimum version that does work? is it v18? Technically, this is just for testing and assembling a release, it is not a functional limitation, so I am quite ok to up min node version to 18, if needed ;) |
Other than that, as I went through the scope of changes - that looks huge! I'm particularly intrigued by the addition of |
Looks like v18 works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple things - comments in JSON, plus the Node version.
First thing to note, I replaced ts-node with tsx. |
Thank you for the clarification! 🤗 |
LGTM, thank you for this incredible work, I would not have been able to make it myself! Leaving it for you to merge whenever you think it is ready 😉 |
fix #236
It looks like a lot but most of it is just lining updates.
Look at just the first commit to see what's actually changed.