-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests error on Windows #241
Comments
So I have done some more testing, including on Mac, and I can now confirm that the issue is Windows-specific. I had no issues whatsoever on Mac. Specifically, it is Unfortunately, Windows 11 is my main rig here, so I need to figure it out. Any help is much appreciated! |
Got a potential fix. Weird thing is that one of the tests are failing for me now on windows. |
That PR does work for me!!! :) I also see some test issues, but only sometimes, that's because there are some race-condition tests that were tuned to pass under the current test framework. I will just need to fine-tune them a little now that the test framework is different, and it may effect timings for some race tests. |
Figured it out. It's a timing bug. |
Actually, maybe not a bug as such. It looks more intentional so I guess an issue with the test. |
Values for the test were tuned to pass under the current test framework. But since it is a race-condition test, timings change when the test framework changes, so needs to be updated to pass both on Linux and Windows. That's not something to worry about, I can update any such troubling test ;) |
Alright, I'll leave that all to you. I did make an issue though #243 |
Cannot run tests, after the DEV Dependencies PR:
Running
npm test
produces the above error for me. Could be because I use Windows 11 here? I haven't tried it on Mac yet, will do a little later, if needed. It reproduces using NodeJS 18, 20 and 22.P.S. I did remove all installed dependencies and reinstalled everything.
The text was updated successfully, but these errors were encountered: