Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug where logs do not properly get updated in significant size simulations. #1394

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

CodeByDrescher
Copy link
Contributor

Identified two sibling race conditions causing logs to be inaccurate under certain circumstances:

If VCell CLI ran a "heavier" simulation, it would encounter one of two different race conditions:

  1. Java attempts to move the "final" log files from the temporary directory to the actual output directory, however python was not yet finished editing the file.
  2. Java attempts to forcefully close the python shell it was using, before python had the chance to update the logs.

Both cases have been remedied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant