Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Infinity and NaN in SBML values and MathML #1381

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

jcschaff
Copy link
Member

@jcschaff jcschaff commented Nov 14, 2024

SBML Import from MathML now supports NaN and Infinity (with MathML unit test)

  • <notanumber/> MathML imported as new Expression("0/0")
  • <infinity/> MathML imported as new Expression(Double.MAX_VALUE)

SBML Import with float values (e.g. value attributes) support NaN and Infinity

  • Double.NaN => new Expression("0/0")
  • Double.POSITIVE_INFINITY => new Expression(Double.MAX_VALUE)
  • Double.NEGATIVE_INFINITY => new Expression(-Double.MAX_VALUE)

@jcschaff jcschaff self-assigned this Nov 14, 2024
Copy link
Contributor

@CodeByDrescher CodeByDrescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; it's interesting seeing how VCell interprets the needed values!

@jcschaff jcschaff merged commit a46a9ef into master Nov 15, 2024
13 checks passed
@jcschaff jcschaff deleted the sbml-nan-and-infinity branch November 15, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants