Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix admin url include #26

Merged
merged 3 commits into from
May 20, 2024
Merged

Fix admin url include #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7bd56e
Fix admin url include
pamella May 20, 2024
fe7aa17
Add supported django versions badge to README
pamella May 20, 2024
3ab0874
Update URL for consistency
pamella May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

![PyPI - Version](https://img.shields.io/pypi/v/django-celerybeat-status)
![Supported Python Versions](https://img.shields.io/pypi/pyversions/django-celerybeat-status.svg)
![Supported Django Versions](https://img.shields.io/pypi/frameworkversions/django/django-celerybeat-status.svg)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by addition.

[![Build Status](https://github.com/vintasoftware/django-celerybeat-status/actions/workflows/tests.yml/badge.svg)](https://github.com/vintasoftware/django-celerybeat-status/actions/workflows/tests.yml)
[![Coverage Status](https://coveralls.io/repos/github/vintasoftware/django-celerybeat-status/badge.svg?branch=main)](https://coveralls.io/github/vintasoftware/django-celerybeat-status?branch=main)

Expand Down Expand Up @@ -31,7 +32,8 @@ from django.urls import include, path

urlpatterns = [
# other urls...
path("admin/statuscheck/", include("celerybeat_status.urls", namespace="celerybeat_status")),
path("admin/statuscheck/", include("celerybeat_status.urls")), # celerybeat_status admin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to use namespace. I also updated the test app.

path("admin/", admin.site.urls), # django admin
]
```

Expand Down
2 changes: 1 addition & 1 deletion celerybeat_status/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# -*- coding: utf-8
__title__ = "CeleryBeat Status"
__version__ = "1.0.0"
__version__ = "1.0.1"
__author__ = "Vinta Software"
__license__ = "MIT License"
__copyright__ = "Copyright 2017 Vinta Serviços e Soluções Tecnológicas Ltda"
Expand Down
2 changes: 1 addition & 1 deletion celerybeat_status/templates/celerybeat_status/periodic_tasks_status_list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
{% block breadcrumbs %}
<div class="breadcrumbs">
<a href="{% url 'admin:index' %}">{% trans 'Home' %}</a> &rsaquo;
<a href="{% url 'periodic-tasks-status' %}">{% trans 'Periodic tasks status' %}</a>
<a href="{% url 'celerybeat_status:periodic-tasks-status' %}">{% trans 'Periodic tasks status' %}</a>
</div>
{% endblock %}

Expand Down
5 changes: 1 addition & 4 deletions tests/urls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
urlpatterns = [
# The new admin catch-all view will break URL patterns routed after the admin URLs and matching
# the admin URL prefix. Source: https://docs.djangoproject.com/en/5.0/releases/3.2/#id1
path(
"admin/statuscheck/",
include("celerybeat_status.urls", namespace="celerybeat_status"),
),
path("admin/statuscheck/", include("celerybeat_status.urls")),
path("admin/", admin.site.urls),
]