Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix admin url include #26

Merged
merged 3 commits into from
May 20, 2024
Merged

Fix admin url include #26

merged 3 commits into from
May 20, 2024

Conversation

pamella
Copy link
Contributor

@pamella pamella commented May 20, 2024

Description

While using the 1.0.0 version on a project, an error was raised due to the usage of the namespace argument, which isn't necessary.

Relates to #24

@@ -2,6 +2,7 @@

![PyPI - Version](https://img.shields.io/pypi/v/django-celerybeat-status)
![Supported Python Versions](https://img.shields.io/pypi/pyversions/django-celerybeat-status.svg)
![Supported Django Versions](https://img.shields.io/pypi/frameworkversions/django/django-celerybeat-status.svg)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by addition.

@@ -31,7 +32,8 @@ from django.urls import include, path

urlpatterns = [
# other urls...
path("admin/statuscheck/", include("celerybeat_status.urls", namespace="celerybeat_status")),
path("admin/statuscheck/", include("celerybeat_status.urls")), # celerybeat_status admin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to use namespace. I also updated the test app.

@pamella pamella requested a review from fjsj May 20, 2024 15:44
@pamella pamella merged commit c75c219 into main May 20, 2024
22 checks passed
@pamella pamella deleted the fix/urls-include branch May 20, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants