-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Django 4.2 and 5.0, and drop support for prior versions #24
Conversation
Support for django versions older than 4 is retained.
|
||
if __name__ == "__main__": | ||
main() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to keep this manage.py?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In django-virtual-models, I have a separate example folder: https://github.com/vintasoftware/django-virtual-models
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe folks did it like that because of the need to add celerybeat_status
to INSTALLED_APPS
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would renaming the tests
folder to example
be a middle ground?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to find an example with the manage.py
, but so far I believe we have it so we can run and render the admin UI for testing/QA purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a tests folder is fine, but that's where the tests are, not the examples.
The idea for having a tests dir is to not distribute it along with the main app (it's not installed via pip for example)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, but the tests
folders have auxiliary files besides the test_*
ones. For example:
django-rest-framework
hasmodels.py
andurls.py
.django-cors-headers
hassettings.py
andurls.py
.
We would be doing something similar here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that's fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Django own code also does this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. What's missing?
The TODO items from the description:
|
@fjsj The PR is ready for review. I will add the release GitHub action in another PR. |
Description
codecov
withcoveralls
.black
andisort
.ℹ️ Related to #23.
Related issues
Screenshots
Screencast.from.16-05-2024.19.16.15.webm