Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Django 4.2 and 5.0, and drop support for prior versions #24

Merged
merged 19 commits into from
May 20, 2024

Conversation

pamella
Copy link
Contributor

@pamella pamella commented May 16, 2024

Description

ℹ️ Related to #23.

Related issues

Screenshots

  • Run the project.
  • Check if the admin pages are working properly.
Screencast.from.16-05-2024.19.16.15.webm

@pamella pamella requested a review from fjsj May 16, 2024 22:12

if __name__ == "__main__":
main()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep this manage.py?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In django-virtual-models, I have a separate example folder: https://github.com/vintasoftware/django-virtual-models

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe folks did it like that because of the need to add celerybeat_status to INSTALLED_APPS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would renaming the tests folder to example be a middle ground?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to find an example with the manage.py, but so far I believe we have it so we can run and render the admin UI for testing/QA purposes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a tests folder is fine, but that's where the tests are, not the examples.
The idea for having a tests dir is to not distribute it along with the main app (it's not installed via pip for example)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, but the tests folders have auxiliary files besides the test_* ones. For example:

We would be doing something similar here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's fine

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Django own code also does this.

Copy link
Member

@fjsj fjsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. What's missing?

@pamella
Copy link
Contributor Author

pamella commented May 17, 2024

Overall LGTM. What's missing?

The TODO items from the description:

  • Add GitHub action to address the release process.
  • Update README with the new Django syntax and instructions on how to run/contribute to this project.

@pamella pamella marked this pull request as ready for review May 17, 2024 17:28
@pamella
Copy link
Contributor Author

pamella commented May 17, 2024

@fjsj The PR is ready for review. I will add the release GitHub action in another PR.

@fjsj fjsj merged commit 7a7a649 into main May 20, 2024
22 checks passed
@fjsj fjsj deleted the feat/django-v5 branch May 20, 2024 13:50
@pamella pamella mentioned this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants