Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/main' into jonmmease/vega-lite-5…
Browse files Browse the repository at this point in the history
….16.3
  • Loading branch information
jonmmease committed Nov 23, 2023
2 parents b1414cd + 1e17571 commit 44e4020
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
9 changes: 9 additions & 0 deletions NOTES_FOR_MAINTAINERS.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,15 @@ of some docstrings.
Major version updates (e.g. Vega-Lite 1.X->2.X) have required substantial
rewrites, because the internal structure of the schema changed appreciably.

## Updating the Vega-Lite in JupyterChart
To update the Vega-Lite version used in JupyterChart, update the version in the esm.sh URL in `altair/jupyter/js/index.js`.

For example, to update to Vega-Lite 5.15.1, Vega 5 and Vega-Embed 6, the URL should be:

```javascript
import embed from "https://esm.sh/vega-embed@6?deps=vega@5&[email protected]";
```

### Updating vl-convert version bound
When updating the version of Vega-Lite, it's important to ensure that
[vl-convert](https://github.com/vega/vl-convert) includes support for the new Vega-Lite version.
Expand Down
4 changes: 2 additions & 2 deletions altair/jupyter/js/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import embed from "https://cdn.jsdelivr.net/npm/vega-embed@6/+esm";
import debounce from "https://cdn.jsdelivr.net/npm/[email protected]/debounce/+esm";
import embed from "https://esm.sh/vega-embed@6?deps=vega@5&[email protected]";
import debounce from "https://esm.sh/[email protected]/debounce";

export async function render({ model, el }) {
let finalize;
Expand Down

0 comments on commit 44e4020

Please sign in to comment.