-
Notifications
You must be signed in to change notification settings - Fork 794
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix broken JupyterWidget chart by pinning Vega (#3269)
* Use latest Vega from esm.sh and pin Vega-Lite to the version Altair is expecting. * Add note to NOTES_FOR_MAINTAINERS.md to update the Vega-Lite version in JupyterChart.
- Loading branch information
Showing
2 changed files
with
11 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,6 +49,15 @@ of some docstrings. | |
Major version updates (e.g. Vega-Lite 1.X->2.X) have required substantial | ||
rewrites, because the internal structure of the schema changed appreciably. | ||
|
||
## Updating the Vega-Lite in JupyterChart | ||
To update the Vega-Lite version used in JupyterChart, update the version in the esm.sh URL in `altair/jupyter/js/index.js`. | ||
|
||
For example, to update to Vega-Lite 5.15.1, Vega 5 and Vega-Embed 6, the URL should be: | ||
|
||
```javascript | ||
import embed from "https://esm.sh/vega-embed@6?deps=vega@5&[email protected]"; | ||
``` | ||
|
||
### Updating vl-convert version bound | ||
When updating the version of Vega-Lite, it's important to ensure that | ||
[vl-convert](https://github.com/vega/vl-convert) includes support for the new Vega-Lite version. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
import embed from "https://cdn.jsdelivr.net/npm/vega-embed@6/+esm"; | ||
import debounce from "https://cdn.jsdelivr.net/npm/[email protected]/debounce/+esm"; | ||
import embed from "https://esm.sh/vega-embed@6?deps=vega@5&[email protected]"; | ||
import debounce from "https://esm.sh/[email protected]/debounce"; | ||
|
||
export async function render({ model, el }) { | ||
let finalize; | ||
|