Make the strategy more sensible #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the strategy more sensible and potentially more profitable.
Adamantios
commented
Sep 6, 2023
| bet_amount = self.params.get_bet_amount(confidence) | ||
| fee = self.synchronized_data.sampled_bet.fee | ||
| return bet_amount - fee >= bet_threshold | ||
| potential_net_profit = num_shares - net_bet_amount - mech_price - bet_threshold |
There was a problem hiding this comment.
I believe that the mech's price should be removed from the profitability calculation as this has already been paid.
If 0 < num_shares - net_bet_amount - bet_threshold < mech_price, then the service would at least have a chance to cover a part of the mech's costs plus the threshold's amount.
There was a problem hiding this comment.
Yes it can be removed.
There was a problem hiding this comment.
Ok! We need to add the mech cost to the outer decision making problem later
0xArdi
approved these changes
Sep 6, 2023
Adamantios
commented
Sep 6, 2023
Comment on lines
+226
to
+227
| def _calc_binary_shares(self, net_bet_amount: int, vote: int) -> Tuple[int, int]: | ||
| """Calculate the claimed shares. This calculation only works for binary markets.""" |
There was a problem hiding this comment.
The output of this method was tested with multiple examples and the returned number of shares is accurate.
jmoreira-valory
approved these changes
Sep 6, 2023
Add slippage
Fix exception handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the strategy more sensible and potentially more profitable.