Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/tools #208

Merged
merged 11 commits into from
Apr 8, 2024
Merged

Fix/tools #208

merged 11 commits into from
Apr 8, 2024

Conversation

0xArdi
Copy link
Collaborator

@0xArdi 0xArdi commented Apr 8, 2024

This PR performs multiple fixes on the tools as a result of the recent failures.

0xArdi added 6 commits April 8, 2024 13:02
# Conflicts:
#	packages/packages.json
#	packages/valory/agents/mech/aea-config.yaml
#	packages/valory/customs/prediction_request_claude/component.yaml
#	packages/valory/customs/prediction_request_claude/prediction_request_claude.py
#	packages/valory/customs/prepare_tx/component.yaml
#	packages/valory/customs/prepare_tx/prepare_tx.py
#	packages/valory/services/mech/service.yaml
temperature=temperature,
max_tokens=max_tokens,
)
try:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardblythman @moarshy Wrapping in a try/except like this really helps to debug when things go wrong. I suggest we take this approach going forward. If you have some cleaner way of doing it than with simple try/except like this please propose.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK sure, sounds good.

Comment on lines +796 to +797
except Exception as e:
return f"Invalid response. The following issue was encountered: {str(e)}", "", None, None
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check response here

@@ -482,6 +482,7 @@ def run(**kwargs) -> Tuple[str, Optional[str], Optional[Dict[str, Any]], Any]:
"Moderation flagged the prompt as in violation of terms.",
prediction_prompt,
None,
counter_callback,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was missing on this branch of exec. lead to failure

Comment on lines +122 to +125
moviepy:
version: ==1.0.3
replicate:
version: ==0.15.7
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

required by the shorts tool

@@ -68,4 +68,4 @@ readability-lxml = "0.8.1"
docstring-parser = "0.15"
faiss-cpu = "1.7.4"
pypdf2 = "^3.0.1"
lxml = {extras = ["html-clean"], version = "^5.2.0"}
lxml = {extras = ["html-clean"], version = "^5.1.0"}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.2.0 caused issues, moved to 5.1.0 seems to be stable

@@ -64,7 +64,7 @@ deps =
pandas==2.1.1
tiktoken==0.5.1
python-dateutil==2.8.2
lxml==5.2.0
lxml==5.1.0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

component.yaml files MUST be added

@0xArdi 0xArdi merged commit 0179545 into main Apr 8, 2024
6 checks passed
@0xArdi 0xArdi deleted the fix/tools branch April 8, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants