chore: use lockfileVersion 3, add test-fixture dev dependency #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
changed the title
DiegoCardoso
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With
"lockfileVersion": 3, it turns out that@polymer/test-fixturedev dependency (which is transitive and comes fromwct-browser-legacy) gets installed into nested subfoldernode_modules/wct-browser-legacy/node_modules.In order to make sure tests run in P3, I added direct dev dependency on
test-fixturetobower.jsonwhich gets mapped to v4.0.0 (see Polymer/tools#703). Previously it broke due towct-browser-legacyusing v3 internally.Type of change