Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix charts build #625

Merged
merged 13 commits into from
Oct 25, 2024
Merged

chore: fix charts build #625

merged 13 commits into from
Oct 25, 2024

Conversation

DiegoCardoso
Copy link
Contributor

@DiegoCardoso DiegoCardoso commented Oct 21, 2024

Description

Fix a few issues with the project CI build:

  • Move visual tests into devDependencies to be able to override tough-cookie dependency to a version supported by Node 12
    • One of gemini's dependency was too permissive about its own dependencies, which caused [email protected] being picked, which does not support Node 12
  • Update GH Actions to V4
  • Disable W3C in the configuration for the Android Emulator test
  • Disable the exporting tests as this was causing the test to timeout (it needs some investigation of its cause)

test/test-suites.js Outdated Show resolved Hide resolved
This reverts commit e76dfed.
@DiegoCardoso DiegoCardoso changed the title test v14 buid chore: fix charts build Oct 24, 2024
@DiegoCardoso DiegoCardoso merged commit 3563e18 into master Oct 25, 2024
4 checks passed
@DiegoCardoso DiegoCardoso deleted the test-build branch October 25, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants