Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#73 my home&notice #76

Merged
merged 27 commits into from
Dec 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
9056f9c
feat/#73 : MyInfoScreen UI
BEEEAM-J Dec 26, 2023
9206207
feat/#73 : NoticeScreen UI
BEEEAM-J Dec 26, 2023
e4e96ef
feat/#73 : NoticeDetailScreen UI
BEEEAM-J Dec 26, 2023
6c2a379
feat/#73 : my ํ™ˆ -> Notice -> NoticeDetail ์ด๋™ ๊ตฌํ˜„
BEEEAM-J Dec 27, 2023
05149e1
feat/#73 :MyInfo, Notice, NoticeDetail ์ƒํƒœ ๊ด€๋ฆฌ
BEEEAM-J Dec 27, 2023
2db9956
Merge branch 'develop' into feature/#73-my-home&notice
BEEEAM-J Dec 28, 2023
49a4524
comment/#73 : ์ฃผ์„ ์ œ๊ฑฐ ๋ฐ ํ•ด์ œ
BEEEAM-J Dec 28, 2023
2a9e13e
feat/#73 : Notice, NoticeDetail Loading Screen
BEEEAM-J Dec 28, 2023
81dbf8c
feat/#73 : UseCase ์ ์šฉ
BEEEAM-J Dec 28, 2023
95538fc
chore/#73 : ktlint
BEEEAM-J Dec 28, 2023
7c4eaa4
refactor/#73 : MyInfo State ์ˆ˜์ •
BEEEAM-J Dec 28, 2023
548c043
fix/#73 : ํฐํŠธ ํฌ๊ธฐ์— ๋”ฐ๋ผ MyInfoScreen ๋‚ด๋ถ€ ์ปดํฌ๋„ŒํŠธ๋“ค์ด ์ž˜๋ฆฌ๋Š” ๋ฌธ์ œ ์ˆ˜์ •
BEEEAM-J Dec 28, 2023
6eae87b
rename/#73 : SuwikiBottomSheetItem -> SuwikiMenuItem
BEEEAM-J Dec 28, 2023
de5b791
rename/#73 : LoginMyInfo, LogoutMyInfo -> LoginMyInfoCard, LogoutMyInโ€ฆ
BEEEAM-J Dec 28, 2023
b154a76
refactor/#73 : NoticeDetailScreen Scaffold -> Column ๋ณ€๊ฒฝ
BEEEAM-J Dec 28, 2023
e244dad
refactor/#73 : SuwikiAppBarWithTitle
BEEEAM-J Dec 28, 2023
d2e0fcd
refactor/#73 : NoticeDetailScreen AppBar
BEEEAM-J Dec 28, 2023
a76a209
refactor/#73 : NoticeScreen
BEEEAM-J Dec 28, 2023
4b8f1c2
refactor/#73 : MyInfoScreen LazyColumn -> Column
BEEEAM-J Dec 29, 2023
c7940f4
refactor/#73 : ViewModel init ํ•จ์ˆ˜ ์ œ๊ฑฐ, ํ•จ์ˆ˜๋ช… ๋ณ€๊ฒฝ, uiState ์ˆ˜์ •
BEEEAM-J Dec 29, 2023
1ba12a6
chore/#73 : ktlint
BEEEAM-J Dec 29, 2023
2798528
refactor/#73 : 75๋ฒˆ ๋ธŒ๋žœ์น˜ SuwikiAppBarWithTitle๋กœ ์ˆ˜์ •
BEEEAM-J Dec 30, 2023
7844f09
refactor/#73 : Column Scroll ๋ฒ”์œ„ ์ˆ˜์ •
BEEEAM-J Dec 30, 2023
3814d36
refactor/#73 : noticeList type ์ˆ˜์ •
BEEEAM-J Dec 30, 2023
f16d7bb
refactor/#73 : noticeDetail Stable๋กœ ๋ณ€๊ฒฝ
BEEEAM-J Dec 30, 2023
e0e6cec
feat/#73 : ์„œ๋ฒ„ ํ†ต์‹  ์‹คํŒจ ์ฒ˜๋ฆฌ
BEEEAM-J Dec 30, 2023
9e026b0
chore/#73 : ktlint
BEEEAM-J Dec 30, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
package com.suwiki.core.designsystem.component.appbar

import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
Expand All @@ -11,6 +10,7 @@ import androidx.compose.foundation.shape.CircleShape
import androidx.compose.material3.Icon
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.clip
import androidx.compose.ui.res.painterResource
Expand All @@ -25,42 +25,54 @@ import com.suwiki.core.ui.extension.suwikiClickable
@Composable
fun SuwikiAppBarWithTitle(
modifier: Modifier = Modifier,
title: String = "",
title: String? = null,
showCloseIcon: Boolean = true,
showBackIcon: Boolean = true,
onClickBack: () -> Unit = {},
onClickRemove: () -> Unit = {},
onClickClose: () -> Unit = {},
) {
Row(
Box(
modifier = modifier
.fillMaxWidth()
.wrapContentHeight()
.background(White)
.padding(top = 15.dp, bottom = 15.dp, start = 18.dp, end = 24.dp),
horizontalArrangement = Arrangement.SpaceBetween,
) {
Icon(
painter = painterResource(id = R.drawable.ic_appbar_arrow_left),
contentDescription = "",
tint = Gray95,
modifier = Modifier
.size(24.dp)
.clip(CircleShape)
.suwikiClickable(onClick = onClickBack)
.padding(vertical = 2.dp, horizontal = 6.5.dp),
)
Text(
text = title,
style = SuwikiTheme.typography.header6,
)
Icon(
painter = painterResource(id = R.drawable.ic_appbar_close_mark),
contentDescription = "",
tint = Gray95,
modifier = Modifier
.size(24.dp)
.clip(CircleShape)
.suwikiClickable(onClick = onClickRemove)
.padding(3.dp),
)
if (showBackIcon) {
Icon(
modifier = Modifier
.align(Alignment.CenterStart)
.size(24.dp)
.clip(CircleShape)
.suwikiClickable(onClick = onClickBack)
.padding(vertical = 2.dp, horizontal = 6.5.dp),
painter = painterResource(id = R.drawable.ic_appbar_arrow_left),
contentDescription = "",
tint = Gray95,
)
}

if (title != null) {
Text(
modifier = Modifier.align(Alignment.Center),
text = title,
style = SuwikiTheme.typography.header6,
)
}

if (showCloseIcon) {
Icon(
modifier = Modifier
.align(Alignment.CenterEnd)
.size(24.dp)
.clip(CircleShape)
.suwikiClickable(onClick = onClickClose)
.padding(3.dp),
painter = painterResource(id = R.drawable.ic_appbar_close_mark),
contentDescription = "",
tint = Gray95,
)
}
}
}

Expand All @@ -71,7 +83,7 @@ fun SuwikiAppBarPreview() {
SuwikiAppBarWithTitle(
title = "ํƒ€์ดํ‹€",
onClickBack = { /*TODO*/ },
onClickRemove = { /*TODO*/ },
onClickClose = { /*TODO*/ },
)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ fun SuwikiBottomSheet(
}

@Composable
fun SuwikiBottomSheetItem(
fun SuwikiMenuItem(
modifier: Modifier = Modifier,
title: String,
) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package com.suwiki.core.model.notice
import java.time.LocalDateTime

data class Notice(
val id: Long,
val title: String,
val date: LocalDateTime?,
val id: Long = 0,
val title: String = "",
val date: LocalDateTime? = null,
)
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ package com.suwiki.core.model.notice
import java.time.LocalDateTime

data class NoticeDetail(
val id: Long,
val title: String,
val date: LocalDateTime?,
val content: String,
val id: Long = 0,
val title: String = "",
val date: LocalDateTime? = null,
val content: String = "",
)
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
package com.suwiki.feature.myinfo

data class MyInfoState(
val showMyInfoCard: Boolean = false,
val isLoading: Boolean = false,
)

sealed interface MyInfoSideEffect {
data object NavigateNotice : MyInfoSideEffect
}
Loading