Feature/#73 my home¬ice #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO(ViewModel 적용 시 발생하는 오류 해결 필요)
# Conflicts: # feature/navigator/src/main/java/com/suwiki/feature/navigator/MainNavigator.kt
jinukeu
requested changes
Dec 28, 2023
| MyInfoScreen( | ||
| padding = padding, | ||
| uiState = uiState, | ||
| onClickNoticeButton = { viewModel.navigateNotice() }, |
There was a problem hiding this comment.
Suggested change
| onClickNoticeButton = { viewModel.navigateNotice() }, | |
| onClickNoticeButton = viewModel::navigateNotice, |
feature/myinfo/src/main/java/com/suwiki/feature/myinfo/MyInfoScreen.kt
Outdated
Show resolved
Hide resolved
feature/myinfo/src/main/java/com/suwiki/feature/myinfo/MyInfoScreen.kt
Outdated
Show resolved
Hide resolved
feature/myinfo/src/main/java/com/suwiki/feature/myinfo/MyInfoScreen.kt
Outdated
Show resolved
Hide resolved
feature/myinfo/src/main/java/com/suwiki/feature/myinfo/MyInfoScreen.kt
Outdated
Show resolved
Hide resolved
feature/notice/src/main/java/com/suwiki/feature/notice/NoticeDetailScreen.kt
Show resolved
Hide resolved
feature/notice/src/main/java/com/suwiki/feature/notice/NoticeDetailViewModel.kt
Outdated
Show resolved
Hide resolved
feature/notice/src/main/java/com/suwiki/feature/notice/NoticeDetailViewModel.kt
Outdated
Show resolved
Hide resolved
feature/notice/src/main/java/com/suwiki/feature/notice/NoticeDetailViewModel.kt
Outdated
Show resolved
Hide resolved
feature/notice/src/main/java/com/suwiki/feature/notice/NoticeScreen.kt
Outdated
Show resolved
Hide resolved
|
피드백 전부 반영했습니다. |
jinukeu
requested changes
Dec 29, 2023
...nsystem/src/main/java/com/suwiki/core/designsystem/component/appbar/SuwikiAppBarWithTitle.kt
Outdated
Show resolved
Hide resolved
feature/myinfo/src/main/java/com/suwiki/feature/myinfo/MyInfoScreen.kt
Outdated
Show resolved
Hide resolved
feature/notice/src/main/java/com/suwiki/feature/notice/NoticeContract.kt
Outdated
Show resolved
Hide resolved
feature/notice/src/main/java/com/suwiki/feature/notice/NoticeDetailContract.kt
Show resolved
Hide resolved
feature/notice/src/main/java/com/suwiki/feature/notice/NoticeDetailScreen.kt
Outdated
Show resolved
Hide resolved
feature/notice/src/main/java/com/suwiki/feature/notice/NoticeDetailViewModel.kt
Outdated
Show resolved
Hide resolved
feature/notice/src/main/java/com/suwiki/feature/notice/NoticeScreen.kt
Outdated
Show resolved
Hide resolved
jinukeu
reviewed
Dec 30, 2023
Comment on lines
+59
to
+61
| LaunchedEffect(key1 = viewModel) { | ||
| viewModel.checkLoggedIn() | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 PR 요약
🌱 작업한 내용
🌱 PR 포인트
🌱 PR 포인트2
📸 스크린샷
📮 관련 이슈