Bug fixed ExoPlayerAnalyticalListenerImp suppressed for now since it …

…was causing fatal crashing on some build
urban-health-labs · Oct 13, 2019 · ad6d388 · ad6d388
1 parent 8bb29b4
commit ad6d388
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -19,7 +19,7 @@ allprojects {
 Add following in build.gradle (App level):
 ```
 dependencies {
-	implementation 'com.github.rever-ai:goonj:0.4.3'
+	implementation 'com.github.rever-ai:goonj:0.5'
 	// Exo Player
     implementation 'com.google.android.exoplayer:exoplayer-core:2.10.3'
     implementation 'com.google.android.exoplayer:exoplayer-ui:2.10.3'

diff --git a/goonj/src/main/java/ai/rever/goonj/analytics/ItemActionCallbackImp.kt b/goonj/src/main/java/ai/rever/goonj/analytics/ItemActionCallbackImp.kt
@@ -7,6 +7,8 @@ import androidx.mediarouter.media.RemotePlaybackClient
 
 open class ItemActionCallbackImp(var operation: String, var onSuccess: ((String?, MediaItemStatus?) -> Unit)? = null) : RemotePlaybackClient.ItemActionCallback() {
 
+
+
     override fun onResult(
         data: Bundle?,
         sessionId: String?,

diff --git a/goonj/src/main/java/ai/rever/goonj/player/LocalAudioPlayer.kt b/goonj/src/main/java/ai/rever/goonj/player/LocalAudioPlayer.kt
@@ -163,7 +163,7 @@ internal class LocalAudioPlayer: AudioPlayer {
     }
 
     private fun addListeners(){
-        player?.addAnalyticsListener(ExoPlayerAnalyticsListenerImp)
+//        player?.addAnalyticsListener(ExoPlayerAnalyticsListenerImp)
         player?.addListener(eventListener)
     }
 
@@ -181,7 +181,7 @@ internal class LocalAudioPlayer: AudioPlayer {
 
         GoonjSessionMediaConnector.release()
 
-        player?.removeAnalyticsListener(ExoPlayerAnalyticsListenerImp)
+//        player?.removeAnalyticsListener(ExoPlayerAnalyticsListenerImp)
         player?.removeListener(eventListener)
         player?.release()
         player = null