-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Unkey PDF Viewer template [SIDE QUEST] #2191
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Caution Review failedThe pull request is closed. 📝 Walkthrough📝 WalkthroughWalkthroughThe pull request updates the template creation guidelines for the Unkey framework. It adds new requirements regarding duplicate checks, open-source project commitments, and licensing under the MIT license. Additionally, it retains the requirement for a README.md file with a quickstart guide and introduces two new example projects with links to their GitHub repositories. A new template entry for Changes
Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@unrenamed is attempting to deploy a commit to the Unkey Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions for pull request titles! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
oss.gg/7_create_a_template.md (1)
Line range hint
6-10
: LGTM! Consider adding a clarification about the licensing requirement.The new requirements are clear and align well with the objectives of the side quest. They provide good guidance for participants and ensure the quality of submissions.
Consider clarifying the licensing requirement. You could add a brief explanation of why the MIT license is required and provide a link to the license text for reference.
🧰 Tools
🪛 LanguageTool
[typographical] ~4-~4: After the expression ‘for example’ a comma is usually used.
Context: ... Unkey with a particular framework. For example [Ratelimit your Next.js routes](https:/...(COMMA_FOR_EXAMPLE)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- oss.gg/7_create_a_template.md (2 hunks)
🔇 Additional comments (3)
oss.gg/7_create_a_template.md (3)
31-31
: LGTM! Entry added correctly.The new entry for Harsh Bhat's project follows the required schema and provides all necessary information.
Line range hint
6-33
: Overall changes align well with PR objectives and side quest requirements.The updates to this file successfully address the PR objectives by:
- Adding clear requirements for template submissions, ensuring quality and originality.
- Including new entries that demonstrate the progress of the side quest initiative.
- Specifically adding the entry for the Unkey PDF Viewer template, which aligns with the main objective of this PR.
These changes contribute to the broader "SIDE QUESTS" initiative and provide a clear record of contributions for the hackathon.
32-33
: LGTM! Entry added correctly and aligns with PR objectives.The new entry for Nazar Poshtarenko's project follows the required schema and provides all necessary information. The project title and link match the information provided in the PR objectives, demonstrating time-limited access to specific PDF pages using the Unkey SDK.
To verify the project's alignment with the PR objectives, we can check the repository content:
✅ Verification successful
Verified: Project aligns with PR objectives and uses Unkey SDK
The repository 'unrenamed/unkey-pdf-view' exists and contains multiple references to Unkey packages, APIs, and services throughout the codebase. This strongly indicates that the project is indeed using the Unkey SDK as mentioned in the PR objectives.
While the specific implementation of time-limited access to PDF pages couldn't be directly confirmed through our automated search, the overall use of Unkey in the project is evident. To fully verify the time-sensitive access feature, a manual review of the relevant code would be beneficial.
To complete the verification, please manually check the implementation details related to time-limited access to specific PDF pages using the Unkey SDK.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the content of the Unkey PDF Viewer template repository # Test: Check if the repository exists and contains expected files gh repo view unrenamed/unkey-pdf-view --json name,description,readme,licenseInfo # Test: Check for the presence of Unkey SDK usage in the code gh api /repos/unrenamed/unkey-pdf-view/contents | jq -r '.[].name' | xargs -I {} gh api /repos/unrenamed/unkey-pdf-view/contents/{} | jq -r '.content' | base64 -d | grep -i 'unkey'Length of output: 1498
Script:
#!/bin/bash # Description: Verify the content of the Unkey PDF Viewer template repository # Test: Check if the repository exists and contains expected fields gh repo view unrenamed/unkey-pdf-view --json name,description,licenseInfo # Test: Check for the presence of Unkey SDK usage in the code using ast-grep ast-grep --lang javascript --pattern $'unkey' .Length of output: 228
Script:
#!/bin/bash # Description: Comprehensive verification of Unkey SDK usage in the repository # Test 1: Search for the term 'unkey' in all files rg 'unkey' --ignore-dir=node_modules --ignore-dir=dist # Test 2: Check for Unkey SDK in package.json (for JavaScript projects) fd 'package.json' | xargs grep -i 'unkey' # Test 3: Check for Unkey SDK in other dependency files (e.g., requirements.txt, Pipfile, etc.) fd 'requirements.txt,Pipfile,go.mod,build.gradle' | xargs grep -i 'unkey' # Test 4: Search for Unkey SDK references in documentation files rg 'unkey' --type markdown --type txtLength of output: 26006
Script:
#!/bin/bash # Description: Enhanced verification of Unkey SDK usage in the repository # Test 1: Corrected search for the term 'unkey' in all code files excluding node_modules and dist directories rg 'unkey' --ignore-file node_modules/ --ignore-file dist/ # Test 2: Search for import or require statements related to Unkey SDK in JavaScript and TypeScript files rg 'from\s+["@]unkey' --type js --type jsx --type ts --type tsx # Test 3: Search for import or require statements related to Unkey SDK in other supported languages rg 'import\s+.*\s+from\s+["@]unkey' --type python --type go --type java # Test 4: Verify configuration files for Unkey SDK setup rg 'unkey' --type yaml --type json --type toml --type envLength of output: 300304
This is so cool, thanks for sharing |
Glad you liked it, thanks! I've signed the CLA |
If you have more ideas, feel free to submit more, each one awards 750 points :) |
Awarding unrenamed: 750 points 🕹️ Well done! Check out your new contribution on oss.gg/unrenamed |
* chore: Unkey PDF Viewer template * feat: add template --------- Co-authored-by: chronark <[email protected]>
* feat/mobile-sidbar-sync-with-desktop * fix(billing): add missing subscription fields and audit logging to upgrade flow (#2179) * fix(billing): add missing subscription fields and audit logging to upgrade flow * fix context properties * refactor: query audit logs from planetscale (#2181) * refactor: query audit logs from planetscale * fix: sort logs * [autofix.ci] apply automated fixes * chore: remove csv export * Update apps/dashboard/app/(app)/audit/[bucket]/page.tsx Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fmt: add comma * ci: remove wrong lint command --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore: Unkey PDF Viewer template [SIDE QUEST] (#2191) * chore: Unkey PDF Viewer template * feat: add template --------- Co-authored-by: chronark <[email protected]> * perf: add database indices (#2192) * fix: add header again * docs: Removing pnpm test:routes (#2184) * fix: revalidate /apis after creating new API (#2183) * fix: revalidate /apis after creating new API key * fix: show success message after revalidate suceeds * fix: revalidate cache before routing * chore(deps-dev): bump @types/react-dom from 18.2.25 to 18.3.0 (#2187) Bumps [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom) from 18.2.25 to 18.3.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom) --- updated-dependencies: - dependency-name: "@types/react-dom" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Refactor/workspace-navigation * ran fmt --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Meg Stepp <[email protected]> Co-authored-by: Andreas Thomas <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Nazar Poshtarenko <[email protected]> Co-authored-by: Harsh Shrikant Bhat <[email protected]> Co-authored-by: Gerald Maboshe <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat/mobile-sidbar-sync-with-desktop * fix(billing): add missing subscription fields and audit logging to upgrade flow (unkeyed#2179) * fix(billing): add missing subscription fields and audit logging to upgrade flow * fix context properties * refactor: query audit logs from planetscale (unkeyed#2181) * refactor: query audit logs from planetscale * fix: sort logs * [autofix.ci] apply automated fixes * chore: remove csv export * Update apps/dashboard/app/(app)/audit/[bucket]/page.tsx Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fmt: add comma * ci: remove wrong lint command --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore: Unkey PDF Viewer template [SIDE QUEST] (unkeyed#2191) * chore: Unkey PDF Viewer template * feat: add template --------- Co-authored-by: chronark <[email protected]> * perf: add database indices (unkeyed#2192) * fix: add header again * docs: Removing pnpm test:routes (unkeyed#2184) * fix: revalidate /apis after creating new API (unkeyed#2183) * fix: revalidate /apis after creating new API key * fix: show success message after revalidate suceeds * fix: revalidate cache before routing * chore(deps-dev): bump @types/react-dom from 18.2.25 to 18.3.0 (unkeyed#2187) Bumps [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom) from 18.2.25 to 18.3.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom) --- updated-dependencies: - dependency-name: "@types/react-dom" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Refactor/workspace-navigation * ran fmt --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Meg Stepp <[email protected]> Co-authored-by: Andreas Thomas <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Nazar Poshtarenko <[email protected]> Co-authored-by: Harsh Shrikant Bhat <[email protected]> Co-authored-by: Gerald Maboshe <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add default bytes and prefix * adding bytes and prefix columns in harness * fmt * Await * Resolved changes * typo * Capital and Extra bracket * [autofix.ci] apply automated fixes * feat: mobile-sidbar-sync-with-desktop (#2180) * feat/mobile-sidbar-sync-with-desktop * fix(billing): add missing subscription fields and audit logging to upgrade flow (#2179) * fix(billing): add missing subscription fields and audit logging to upgrade flow * fix context properties * refactor: query audit logs from planetscale (#2181) * refactor: query audit logs from planetscale * fix: sort logs * [autofix.ci] apply automated fixes * chore: remove csv export * Update apps/dashboard/app/(app)/audit/[bucket]/page.tsx Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fmt: add comma * ci: remove wrong lint command --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore: Unkey PDF Viewer template [SIDE QUEST] (#2191) * chore: Unkey PDF Viewer template * feat: add template --------- Co-authored-by: chronark <[email protected]> * perf: add database indices (#2192) * fix: add header again * docs: Removing pnpm test:routes (#2184) * fix: revalidate /apis after creating new API (#2183) * fix: revalidate /apis after creating new API key * fix: show success message after revalidate suceeds * fix: revalidate cache before routing * chore(deps-dev): bump @types/react-dom from 18.2.25 to 18.3.0 (#2187) Bumps [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom) from 18.2.25 to 18.3.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom) --- updated-dependencies: - dependency-name: "@types/react-dom" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Refactor/workspace-navigation * ran fmt --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Meg Stepp <[email protected]> Co-authored-by: Andreas Thomas <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Nazar Poshtarenko <[email protected]> Co-authored-by: Harsh Shrikant Bhat <[email protected]> Co-authored-by: Gerald Maboshe <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: update go sdk code examples to the current sdk version (#2200) * fix: update go sdk code examples to the current sdk version * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Andreas Thomas <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Akshay <[email protected]> Co-authored-by: Meg Stepp <[email protected]> Co-authored-by: Andreas Thomas <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Nazar Poshtarenko <[email protected]> Co-authored-by: Gerald Maboshe <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
What does this PR do?
Adds a demo app showcasing time-limited access to specific PDF pages, restricting full downloads. Example of protecting digital content with temporary access using Unkey SDK. https://github.com/unrenamed/unkey-pdf-view
Summary by CodeRabbit
Summary by CodeRabbit