-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Unkey Spring Boot rate limiting example #2457
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 WalkthroughWalkthroughThe pull request updates the documentation for a side quest related to creating a template for using Unkey with various frameworks or languages to build an API. It specifies submission requirements, including originality, open-source licensing, and the inclusion of a README.md file. It also details the points awarded for participation and includes a new entry for a Spring Boot project implementing rate limiting with Unkey, credited to Harsh Bhat. Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🔇 Additional comments (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@harshsbhat is attempting to deploy a commit to the Unkey Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions for pull request titles! 🙏 |
not sure about this one, ratelimiting in stateful applications is pretty easy already, why would you use unkey? |
Why would I write complex algorithms to manage time/requests when there is an easier highly abstracted option like Unkey? Still if you feel like rate limiting feature won't be used with Java, I am happy to make changes to this and make it a RBAC middleware |
just install a package to do it in memory, the only added value unkey provides is the overrides tbh |
What does this PR do?
Showcases Cost-based ratelimiting using Unkey and Spring Boot. This can help showcase Unkey's power using Java and Spring
Fixes: #2150
Github repo: https://github.com/harshsbhat/UnkeySpringBootExample
Summary by CodeRabbit
New Features
Documentation