CLDR CollationTest: omit simplified radicals #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusicu
requested review from
echeran,
macchiati,
cjchapman,
nedley,
pedberg-icu,
josh-hadley and
Ken-Whistler
This was referenced Aug 17, 2024
|
On this one, I will fix a TODO comment by turning into a note with more information. |
macchiati
previously approved these changes
Aug 19, 2024
|
@macchiati thanks! I just pushed a second commit explaining why we now have more characters in the original Unihan block that don't sort in the improved radical-stroke order, resolving the TODO from my previous PR #909. @echeran FYI |
markusicu
force-pushed
the
colltest-omit-simplified-radicals
branch
from
62e35a5 to
d074ab7
Compare
echeran
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating ICU to the latest Unicode 16 files, I got collation conformance test failures. The CollationTest files are generated with the implicit-weights Han sort order and already omit Han characters that are known to sort differently in that sort order vs. radical-stroke order.
With the recent change to make the CLDR radical-stroke order match the one in UAX38 (unicodetools PR #909), we need to omit some more characters. Characters with traditional and simplified radicals are now intermingled, and some of them now sort differently in implicit-Han vs. radical-stroke order. I changed the CollationTest generator to omit all of the simplified radicals.
No DUCET CollationTest file changes.
Related: