-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make CLDR radical-stroke order = UAX38 #909
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is unclear whether this change accommodates a second non-Chinese simplified radical, which is expressed using three apostrophes, and which is new for Unicode Version 16.0. See the Proposed Update of UAX #38.
I did that three months ago in one of the radical-and-simplified parsers: The refactored parser here, at the end of RadicalStroke.java, handles up to three apostrophes, quoting the 16.0 proposed.html version of UAX38. |
PS: There is no character with a three-apostrophe radical as the primary kRSUnicode value. There are only two characters where such a radical is in the secondary value. This code only uses the primary value. That's why I had missed updating that version of the parser before -- it never saw a triple apostrophe. |
Ah, good. For reference, draft code point U+3347B in the Extension J block (Unicode Version 17.0) will have |
FYI: The output CLDR files are now in unicode-org/cldr#3960. I have updated the description of this PR here with a link for that as well. |
Could I get a review please? Or maybe a rubber stamp? |
done
…On Thu, Aug 15, 2024 at 10:41 AM Markus Scherer ***@***.***> wrote:
Could I get a review please? Or maybe a rubber stamp?
@macchiati <https://github.com/macchiati>?
@pedberg-icu <https://github.com/pedberg-icu> approved the output in
CLDR, maybe you could look at the generator changes here?
—
Reply to this email directly, view it on GitHub
<#909 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMGBJL5FVIYYFBGFVC3ZRTR4PAVCNFSM6AAAAABMPLTH4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJRHAZTOMBQHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
tnx! |
Make the CLDR radical-stroke order of CJK ideographs match the order in UAX38 section 2.1.2 Sorting Algorithm Used by the Radical-Stroke Indexes.
For
Changes:
Other code changes
The modified output goes into CLDR:
The full radical-stroke order is printed into the FractionalUCA.txt file there. (file format documentation)
See the CLDR PR for the diffs.
This change also affects some of the CLDR Chinese tailoring data.
Sample FractionalUCA
[radical]
data diffs: