Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show invariant test results in the diff #646

Merged
merged 15 commits into from
Jan 12, 2024

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Jan 10, 2024

See it in action here, I obviously don’t want to check in invariant test failures.

Split out from #645 since we will probably not merge that one before UTC-178. Fix #612.

@eggrobin eggrobin marked this pull request as ready for review January 10, 2024 16:49
@eggrobin eggrobin requested a review from macchiati January 10, 2024 16:49
markusicu
markusicu previously approved these changes Jan 12, 2024
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks plausible

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tnx

@eggrobin eggrobin merged commit 210204f into unicode-org:main Jan 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show invariant test failures on UnicodeInvariantTest.txt
2 participants