Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially test consistency of grapheme cluster segmentation with canonical equivalence, and fix it for LGCs #645

Merged

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Jan 10, 2024

UTC-178-A24 In PropList.txt, assign the Other_Grapheme_Extend property to eighteen pre-existing characters (U+1715, U+1734, U+1B44, U+1BAA, U+1BF2, U+1BF3, U+A953, U+A9C0, U+111C0, U+11235, U+1134D, U+116B6, U+1193D, U+11F41, U+16FF0, U+16FF1, U+1D166, U+1D16D), as well as to the Tulu-Tigalari vowel signs and looped viramas, and update derived properties. For Unicode Version 16.0. See L2/24-009 item 6.5.

Towards #522.

This would have caught the issue reported by Charlotte Buff in https://www.unicode.org/L2/L2023/23159-pubrev.html#ID20230502072316, as well as unicode-org/properties#229.

In fact, it caught the corresponding issue for Tulu-Tigalari (which only affects legacy grapheme clusters). See the failures in 85eca4e.

@eggrobin eggrobin changed the title Partially test consistency of grapheme cluster segmentation with canonical equivalence Partially test consistency of grapheme cluster segmentation with canonical equivalence, and fix it Jan 10, 2024
@eggrobin eggrobin changed the title Partially test consistency of grapheme cluster segmentation with canonical equivalence, and fix it Partially test consistency of grapheme cluster segmentation with canonical equivalence, and fix it for LGCs Jan 10, 2024
@eggrobin eggrobin marked this pull request as ready for review January 23, 2024 23:47
@eggrobin eggrobin requested a review from markusicu January 23, 2024 23:50
E0020..E007F ; Other_Grapheme_Extend # Cf [96] TAG SPACE..CANCEL TAG

# Total code points: 127
# Total code points: 152
Copy link
Member Author

@eggrobin eggrobin Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: 152-127=25; UTC decided on changing 18 existing characters, and there are 7 more Tulu-Tigalari characters new in 16.0, as noted in the PAG report.

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eggrobin eggrobin merged commit 804018d into unicode-org:main Jan 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants