Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Four Arabic Pegon Characters #435

Merged
merged 17 commits into from
Oct 3, 2023
Merged

Four Arabic Pegon Characters #435

merged 17 commits into from
Oct 3, 2023

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Apr 14, 2023

[172-C3] Consensus: Accept the following four characters for a future version of the standard, with property values as given in L2/22-116:

U+0897 ARABIC PEPET
U+10EC2 ARABIC LETTER DAL WITH TWO DOTS VERTICALLY BELOW
U+10EC3 ARABIC LETTER TAH WITH TWO DOTS VERTICALLY BELOW
U+10EC4 ARABIC LETTER KAF WITH TWO DOTS VERTICALLY BELOW

(Reference: L2/22-116 and section 4b of L2/22-128)

[176-C15] Consensus: The UTC approves the ArabicShaping.txt entries in L2/23-160 item 2.1 (a), replacing those recommended by L2/22-116 and previously approved in UTC-172-C3.

[176-C17] Consensus: The UTC approves the change of canonical combining class for U+0897 ARABIC PEPET to ccc=230, from ccc=0 as approved by UTC-172-C3.

@roozbehp roozbehp marked this pull request as ready for review April 14, 2023 17:10
Copy link
Contributor

@roozbehp roozbehp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ArabicShaping.txt has issues with Joining_Type of the dal-like character and the schematic names of all three.

@LornaSIL
Copy link

I think it should be:

# Arabic Extended-D Characters
10EC2; DAL WITH TWO DOTS VERTICALLY BELOW; R; DAL
10EC3; TAH WITH TWO DOTS VERTICALLY BELOW; D; TAH
10EC4; KAF WITH TWO DOTS VERTICALLY BELOW; D; KAF

@roozbehp
Copy link
Contributor

roozbehp commented Apr 14, 2023

I think it should be:

# Arabic Extended-D Characters
10EC2; DAL WITH TWO DOTS VERTICALLY BELOW; R; DAL
10EC3; TAH WITH TWO DOTS VERTICALLY BELOW; D; TAH
10EC4; KAF WITH TWO DOTS VERTICALLY BELOW; D; KAF

Yes, but with "TWO" replaced by "2" and "VERTICAL" preceding the digit. "DAL WITH VERTICAL 2 DOTS BELOW" etc.

@roozbehp
Copy link
Contributor

roozbehp commented Apr 30, 2023

See also issue #454 for catching issues in the schematic name.

@eggrobin
Copy link
Member Author

eggrobin commented Oct 2, 2023

Checked consistency with Ken’s UnicodeData-16.0.0d6.txt and LineBreak-16.0.0d2.txt.

Copy link
Contributor

@roozbehp roozbehp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eggrobin eggrobin merged commit 6e19f27 into unicode-org:main Oct 3, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants