Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that Joining_Group refines Joining_Type #439

Merged
merged 3 commits into from
May 2, 2023

Conversation

eggrobin
Copy link
Member

Fix #437.

With this test, #435 fails with the following error:

[ERROR] Tests run: 10, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 2.19 s <<< FAILURE! - in org.unicode.propstest.TestProperties
[ERROR] org.unicode.propstest.TestProperties.TestJoiningGroupConsistency  Time elapsed: 0.03 s  <<< FAILURE!
org.opentest4j.AssertionFailedError:
U+062F (د) ARABIC LETTER DAL
and
U+10EC2 (𐻂) ARABIC LETTER DAL WITH TWO DOTS VERTICALLY BELOW
have different joining types but are in the same joining group (Dal)
 ==> expected: <Right_Joining> but was: <Dual_Joining>
        at org.unicode.propstest.TestProperties.lambda$1(TestProperties.java:229)
        at org.unicode.propstest.TestProperties.lambda$0(TestProperties.java:227)
        at org.unicode.propstest.TestProperties.TestJoiningGroupConsistency(TestProperties.java:223)

@eggrobin eggrobin requested a review from macchiati April 15, 2023 03:28
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

please squash-and-merge with a better commit message

FYI @roozbehp

@roozbehp
Copy link
Contributor

roozbehp commented May 2, 2023

I don't know all the internals, but the logic LGTM too.

@eggrobin
Copy link
Member Author

eggrobin commented May 2, 2023

better commit message

By default the squash-and-merge commit message is the name of the PR, so the https://xkcd.com/1296/ messages should not end up in the history :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invariant for ArabicShaping
4 participants