-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-16776 Transform bug in es-fa #3902
CLDR-16776 Transform bug in es-fa #3902
Conversation
@roozbehp, the tests are failing because the 'golden data' test file has different results. Could you check those out, and see if they are ok? If so, I'll fix the test file. |
I checked the errors reported in GitHub. They all appear to be improvements, based on my limited understanding of Spanish pronunciation and a handful of thorough spot checks I did (by searching Google for a recorded pronunciation of the Spanish words). So feel free to fix the golden data test file. |
Great, thanks!
…On Thu, Jul 25, 2024, 12:47 Roozbeh Pournader ***@***.***> wrote:
@roozbehp <https://github.com/roozbehp>, the tests are failing because
the 'golden data' test file has different results.
Could you check those out, and see if they are ok? If so, I'll fix the
test file.
I checked the errors reported in GitHub. They all appear to be
improvements, based on my limited understanding of Spanish pronunciation
and a handful of thorough spot checks I did (by searching Google for a
recorded pronunciation of the Spanish words).
So feel free to fix the golden data test file.
—
Reply to this email directly, view it on GitHub
<#3902 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMCQ5PXBTZLSSDUWSVLZOFI6HAVCNFSM6AAAAABLNRKPZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJRGI3TQNBSGY>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
@roozbehp I made changes in the test file. They were: adahuesca: "آذااویسکا" became "آذااوسکا" You can see what the Spanish sounds like by going to the following URL and hitting the speaker button. BTW, we know that the transliterations can't be perfect, so the bar is: the change shouldn't make things worse. |
Ah, the listing of errors in github wasn't complete, so I'll have to add a few more. |
All the tests pass, so if I can get an approval... |
CLDR-16776
Simple bug.
ALLOW_MANY_COMMITS=true