Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-16776 Transform bug in es-fa #3902

Merged

Conversation

macchiati
Copy link
Member

CLDR-16776

Simple bug.

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

roozbehp
roozbehp previously approved these changes Jul 25, 2024
pedberg-icu
pedberg-icu previously approved these changes Jul 25, 2024
@macchiati
Copy link
Member Author

@roozbehp, the tests are failing because the 'golden data' test file has different results.

Could you check those out, and see if they are ok? If so, I'll fix the test file.

@roozbehp
Copy link
Contributor

@roozbehp, the tests are failing because the 'golden data' test file has different results.

Could you check those out, and see if they are ok? If so, I'll fix the test file.

I checked the errors reported in GitHub. They all appear to be improvements, based on my limited understanding of Spanish pronunciation and a handful of thorough spot checks I did (by searching Google for a recorded pronunciation of the Spanish words).

So feel free to fix the golden data test file.

@macchiati
Copy link
Member Author

macchiati commented Jul 25, 2024 via email

@macchiati macchiati dismissed stale reviews from pedberg-icu and roozbehp via 7e41e7d July 25, 2024 20:13
@macchiati
Copy link
Member Author

macchiati commented Jul 25, 2024

@roozbehp I made changes in the test file. They were:

adahuesca: "آذااویسکا" became "آذااوسکا"
aldehuela: "آلدیاویلا" became "آلدیاولا"
brihuega: "بریاویغا" became "بریاوغا"
escorihuela: "ایسکوریاویلا" became "ایسکوریاولا"
huelago: "اویلاغو" became "اولاغو"
huelamo: "اویلامو" became "اولامو"
huelma: "اویلما" became "اولما"
huelva: "اویلوا" became "اولوا"
huelves: "اویلویس" became "اولویس"
hueneja: "اوینیخا" became "اونیخا"

You can see what the Spanish sounds like by going to the following URL and hitting the speaker button.

https://translate.google.com/?sl=es&tl=en&text=adahuesca%0Aaldehuela%0Abrihuega%0Aescorihuela%0Ahuelago%0Ahuelamo%0Ahuelma%0Ahuelva%0Ahuelves%0Ahueneja&op=translate

BTW, we know that the transliterations can't be perfect, so the bar is: the change shouldn't make things worse.

roozbehp
roozbehp previously approved these changes Jul 25, 2024
@macchiati
Copy link
Member Author

Ah, the listing of errors in github wasn't complete, so I'll have to add a few more.

@macchiati
Copy link
Member Author

All the tests pass, so if I can get an approval...

@macchiati macchiati merged commit a622ceb into unicode-org:main Jul 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants