Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17812 v46 vxml: Update TestExampleGenerator/TestUnicodeSetExamples to match hi change in #3883 #3888

Merged
merged 1 commit into from
Jul 19, 2024
Merged

CLDR-17812 v46 vxml: Update TestExampleGenerator/TestUnicodeSetExamples to match hi change in #3883 #3888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestExampleGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1638,7 +1638,7 @@ public void TestUnicodeSetExamples() {
"hi",
"//ldml/characters/exemplarCharacters[@type=\"auxiliary\"]",
"[ॄ‌‍]",
"〖‎🗝️ ॑ ॒ ॠ ॡ ॻ ॼ ॾ ॿ ऱ ॢ ॣ〗〖❰ZWNJ❱ ≡ cursive non-joiner〗〖❰ZWJ❱ ≡ cursive joiner〗〖❬internal: ❭[ॄ‌‍]〗"
"〖‎🗝️ ॑ ॒ ॠ ॡ ॻ ॼ ॾ ॿ ॢ ॣ〗〖❰ZWNJ❱ ≡ cursive non-joiner〗〖❰ZWJ❱ ≡ cursive joiner〗〖❬internal: ❭[ॄ‌‍]〗"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would be a good example (heh) of where the test would be better off to use canned input data - a static exemplar set content rather than using live input.

TestCLDRFile.testSourceLocale() is an example of where there's a whole separate cldr tree with stabilized data. Maybe we could come up with something similar for examples.

},
// TODO: This test is too fragile. Commented out for discussion in CLDR-17608
// {
Expand Down
Loading