CLDR-17812 v46 vxml: Update TestExampleGenerator/TestUnicodeSetExamples to match hi change in #3883 #3888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es to match hi change in unicode-org#3883
macchiati
approved these changes
Jul 19, 2024
srl295
approved these changes
Jul 19, 2024
srl295
reviewed
Jul 19, 2024
| @@ -1638,7 +1638,7 @@ public void TestUnicodeSetExamples() { | |||
| "hi", | |||
| "//ldml/characters/exemplarCharacters[@type=\"auxiliary\"]", | |||
| "[ॄ]", | |||
| "〖🗝️ ॑ ॒ ॠ ॡ ॻ ॼ ॾ ॿ ऱ ॢ ॣ〗〖❰ZWNJ❱ ≡ cursive non-joiner〗〖❰ZWJ❱ ≡ cursive joiner〗〖❬internal: ❭[ॄ]〗" | |||
| "〖🗝️ ॑ ॒ ॠ ॡ ॻ ॼ ॾ ॿ ॢ ॣ〗〖❰ZWNJ❱ ≡ cursive non-joiner〗〖❰ZWJ❱ ≡ cursive joiner〗〖❬internal: ❭[ॄ]〗" | |||
There was a problem hiding this comment.
this would be a good example (heh) of where the test would be better off to use canned input data - a static exemplar set content rather than using live input.
TestCLDRFile.testSourceLocale() is an example of where there's a whole separate cldr tree with stabilized data. Maybe we could come up with something similar for examples.
srl295
approved these changes
Jul 19, 2024
srl295
added a commit
that referenced
this pull request
Jul 20, 2024
32eea30 CLDR-17812 move to -z FINAL_TESTING (#3890) b9780d0 CLDR-17812 yo_BJ: regen from yo (#3892) c7b9d67 CLDR-17812 blo: drop incomplete groups (#3891) 9f3f4d8 CLDR-17812 v46 vxml fixes for ddls (#3889) 587bde6 CLDR-17812 v46 vxml: Update TestExampleGenerator/TestUnicodeSetExamples to match hi change in #3883 (#3888) 5f124f6 CLDR-17812 v46 vxml: Add {0} for de speed-light-speed one, fix error wording in TestCheckCLDR/TestPlaceholders (#3887) dec0953 CLDR-17812 v46 vxml: update locale for TestAliases/testCountBase (#3886) 9d5d8a8 CLDR-17812 v46 vxml: annotations: ff: reinstate empty file (#3882) e11c389 CLDR-17812 v46 vxml: Regenerate personName test data (#3885) 93ab67c CLDR-17812 v46 vxml: update exemplars to match vetter input (#3883) 2575193 CLDR-17812 v46 vxml: update testdata to match vetter input (#3884) a51bdf0 CLDR-17812 ii: drop yiii numbering system (#3881) ee497ab CLDR-17812 Generate VXML (#3879) Co-authored-by: Steven R. Loomis <[email protected]> Co-authored-by: Peter Edberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17812
merge into #3880
Updated the
hitest in TestExampleGenerator/TestUnicodeSetExamples to match thehii exemplar set change in #3883ALLOW_MANY_COMMITS=true