Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17759 Clicking cell should select even if Info Panel is hidden #3827

Merged
merged 2 commits into from
Jun 27, 2024
Merged

CLDR-17759 Clicking cell should select even if Info Panel is hidden #3827

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92f2296
CLDR-17759 Clicking cell should select even if Info Panel is hidden
btangmu Jun 26, 2024
a57b39e
CLDR-17759 Clicking cell should select even if Info Panel is hidden
btangmu Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tools/cldr-apps/js/src/esm/cldrInfo.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,14 @@ function listen(str, tr, theObj, fn) {
cldrDom.listenFor(theObj, "click", function (e) {
if (panelShouldBeShown()) {
show(str, tr, theObj /* hideIfLast */, fn);
} else if (tr?.sethash) {
// These methods, updateCurrentId and setLastShown may be called from show(), if
// panelShouldBeShown() returned true. If the Info Panel is hidden then they still
// need to be called. Since they don't involve the Info Panel, the implementation
// should be changed to make them independent of the Info Panel and they should be
// called from a different module, not cldrInfo.
cldrLoad.updateCurrentId(tr.sethash);
setLastShown(theObj);
}
cldrEvent.stopPropagation(e);
return false;
Expand Down Expand Up @@ -1009,7 +1017,6 @@ export {
closePanel,
initialize,
listen,
openPanel,
reset,
showItemInfoFn,
showMessage,
Expand Down
Loading