Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17759 Clicking cell should select even if Info Panel is hidden #3827

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

btangmu
Copy link
Member

@btangmu btangmu commented Jun 26, 2024

-Call updateCurrentId and setLastShown directly from listen if Info Panel is hidden

-This is a work-around; the selection should be independent of Info Panel and cldrInfo as stated in new comment

-Remove unused export for openPanel, called only locally

CLDR-17759

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

-Call updateCurrentId and setLastShown directly from listen if Info Panel is hidden

-This is a work-around; the selection should be independent of Info Panel and cldrInfo as stated in new comment
@btangmu btangmu marked this pull request as draft June 26, 2024 17:41
@btangmu btangmu requested a review from srl295 June 26, 2024 17:41
@btangmu
Copy link
Member Author

btangmu commented Jun 26, 2024

@srl295 this is still "draft" since I'd like to test a bit more for unwanted side-effects; testing locally it does fix the bug

srl295
srl295 previously approved these changes Jun 26, 2024
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally a ticket number in the TODO, but seems plausible

-Remove unused export for openPanel, called only locally
@btangmu
Copy link
Member Author

btangmu commented Jun 27, 2024

ideally a ticket number in the TODO, but seems plausible

I intentionally didn't write "TODO" since deeply restructuring this code seems outside the scope of this ticket, and might not happen until we move the whole table to Vue. The comment may be helpful if and when this code gets revised further. "TODO" comments can call too much attention to themselves (often the editor highlights them), to the extent of becoming distracting and counterproductive "wishful thinking", unless there's a specific plan to fix them. My thinking about this has changed a lot over the years; there's a lot of subjectivity and compromise involved...

@btangmu btangmu marked this pull request as ready for review June 27, 2024 15:21
@btangmu btangmu requested a review from srl295 June 27, 2024 15:22
@btangmu
Copy link
Member Author

btangmu commented Jun 27, 2024

This isn't a complete solution; for example, clicking a "click to vote" button for a candidate item should also highlight the cell even if the info panel is closed, but it doesn't; fixing that will involve cldrInfo.wireUpButton...

Nevertheless this does fix the main bug. I think negative side-effects are unlikely, and I haven't found any in testing.

@btangmu
Copy link
Member Author

btangmu commented Jun 27, 2024

BTW note that "selection" has two effects: (1) the URL bar changes to reflect the row clicked on; (2) the cell gets a thick border

@btangmu btangmu merged commit 48ae7c4 into unicode-org:main Jun 27, 2024
11 checks passed
@btangmu btangmu deleted the t17759_a branch June 27, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants