Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17726 make TestTransform.TestLocales less obscure #3803

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Jun 12, 2024

  • this test is sensitive to the current CLDR locales at modern.
  • change the test so that it reports which locales are causing the need for chars in the transforms.

CLDR-17726

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

- this test is sensitive to the current CLDR locales at modern.
- change the test so that it reports *which* locales are causing the need for chars in the transforms.
@srl295 srl295 self-assigned this Jun 12, 2024
@srl295 srl295 requested review from macchiati, AEApple and btangmu June 12, 2024 22:48
AEApple
AEApple previously approved these changes Jun 12, 2024
Copy link
Contributor

@AEApple AEApple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it! I'll rerun the tests after you merge this.

@srl295 srl295 changed the base branch from AEApple-CLDR-17590 to main June 12, 2024 23:10
@srl295 srl295 dismissed AEApple’s stale review June 12, 2024 23:10

The base branch was changed.

@srl295
Copy link
Member Author

srl295 commented Jun 12, 2024

@AEApple it's not super exciting, but the other PR gave this failure with this code in:

Error:  (TestTransforms.java:936)  Error: Transliterator for	Cyrl	missing	4:	[ҲҳҶҷ]=[\u04B2\u04B3\u04B6\u04B7] - needed for locales: tg

@srl295 srl295 merged commit 79eb09c into main Jun 17, 2024
15 checks passed
@srl295 srl295 deleted the cldr-17726/transform-test branch June 17, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants