CLDR-17590 Update coverage levels for Microsoft #3801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srl295
previously approved these changes
Jun 12, 2024
|
Fixed, there's no path to go from 'Done' back to 'Accepted' |
|
Let me know when you've merged, and I'll update the v46 charts |
|
SG! I was going to wait for Manuel to review the PR before merging. If we don't hear back by 2pm, let's just go ahead and merge anyway and fix later if there are any issues. WDYT? |
|
SGTM
…On Wed, Jun 12, 2024 at 10:38 AM Annemarie Apple ***@***.***> wrote:
SG! I was going to wait for Manuel to review the PR before merging. If we
don't hear back by 2pm, let's just go ahead and merge anyway and fix later
if there are any issues. WDYT?
—
Reply to this email directly, view it on GitHub
<#3801 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMA57CT7GTSWJZYRYBTZHCBPTAVCNFSM6AAAAABJGVJ4HOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRTGU3TSNZZGE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
macchiati
previously approved these changes
Jun 12, 2024
|
I’m reviewing now, give me 10 mins and I’ll reply back. Thanks
From: Annemarie Apple ***@***.***>
Sent: Wednesday, June 12, 2024 10:38 AM
To: unicode-org/cldr ***@***.***>
Cc: manuelco-cldr ***@***.***>; Review requested ***@***.***>
Subject: Re: [unicode-org/cldr] CLDR-17590 Update coverage levels for Microsoft (PR #3801)
SG! I was going to wait for Manuel to review the PR before merging. If we don't hear back by 2pm, let's just go ahead and merge anyway and fix later if there are any issues. WDYT?
—
Reply to this email directly, view it on GitHub <#3801 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATZELICXTLNNMTWPZXRCS33ZHCBPTAVCNFSM6AAAAABJGVJ4HOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRTGU3TSNZZGE> .
You are receiving this because your review was requested. <https://github.com/notifications/beacon/ATZELICJ5AXBVJX7AMTKWFTZHCBPTA5CNFSM6AAAAABJGVJ4HOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUA6WNY6.gif> Message ID: ***@***.*** ***@***.***> >
|
|
The changes we discussed looks good. However, I still see a few discrepancies with what I’m tracking. We also have:
* Quechua (qu) at modern
* Norwegian Nynorsk (nn) at modern
* Tajik (tg) at modern
* Tigrinya (ti) at modern
These are not reflected in the locales.txt
Thanks
Manuel
From: ***@***.*** ***@***.***>
Sent: Wednesday, June 12, 2024 1:52 PM
To: 'unicode-org/cldr' ***@***.***>; 'unicode-org/cldr' ***@***.***>
Cc: 'Review requested' ***@***.***>
Subject: RE: [unicode-org/cldr] CLDR-17590 Update coverage levels for Microsoft (PR #3801)
I’m reviewing now, give me 10 mins and I’ll reply back. Thanks
From: Annemarie Apple ***@***.*** ***@***.***> >
Sent: Wednesday, June 12, 2024 10:38 AM
To: unicode-org/cldr ***@***.*** ***@***.***> >
Cc: manuelco-cldr ***@***.*** ***@***.***> >; Review requested ***@***.*** ***@***.***> >
Subject: Re: [unicode-org/cldr] CLDR-17590 Update coverage levels for Microsoft (PR #3801)
SG! I was going to wait for Manuel to review the PR before merging. If we don't hear back by 2pm, let's just go ahead and merge anyway and fix later if there are any issues. WDYT?
—
Reply to this email directly, view it on GitHub <#3801 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATZELICXTLNNMTWPZXRCS33ZHCBPTAVCNFSM6AAAAABJGVJ4HOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRTGU3TSNZZGE> .
You are receiving this because your review was requested. <https://github.com/notifications/beacon/ATZELICJ5AXBVJX7AMTKWFTZHCBPTA5CNFSM6AAAAABJGVJ4HOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUA6WNY6.gif> Message ID: ***@***.*** ***@***.***> >
|
manuelco-cldr
requested changes
Jun 12, 2024
AEApple
added a commit
that referenced
this pull request
Jun 12, 2024
CLDR-17590 Update coverage levels for Microsoft See #3801
AEApple
force-pushed
the
AEApple-CLDR-17590
branch
from
315c10d to
a286b88
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
Okay, please review now, I updated based on your feedback. |
manuelco-cldr
previously approved these changes
Jun 12, 2024
CLDR-17590 Update coverage levels for Microsoft See #3801
AEApple
force-pushed
the
AEApple-CLDR-17590
branch
from
d16703c to
7c952c8
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
manuelco-cldr
previously approved these changes
Jun 12, 2024
|
Tajik (tg) is causing the test failure. I filed #3803 to make the test clearer. Basically, Tajik uses chars that aren't in our Cyrillic to Latin converter. I'm not sure what to say, maybe demote Tajik to be less than modern until the transliterator is fixed? Maybe need a new ticket for the translit? |
|
I’m ok to downgrade or revert the changes for Tajik
From: Steven R. Loomis ***@***.***>
Sent: Wednesday, June 12, 2024 3:51 PM
To: unicode-org/cldr ***@***.***>
Cc: manuelco-cldr ***@***.***>; Review requested ***@***.***>
Subject: Re: [unicode-org/cldr] CLDR-17590 Update coverage levels for Microsoft (PR #3801)
Tajik (tg) is causing the test failure. I filed #3803 <#3803> to make the test clearer.
Basically, Tajik uses chars that aren't in our Cyrillic to Latin converter.
I'm not sure what to say, maybe demote Tajik to be less than modern until the transliterator is fixed? Maybe need a new ticket for the translit?
—
Reply to this email directly, view it on GitHub <#3801 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATZELIFGJTSHJ76SPQUMEITZHDGEZAVCNFSM6AAAAABJGVJ4HOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRUGAZDGNJXHE> .
You are receiving this because your review was requested. <https://github.com/notifications/beacon/ATZELIDPVD6LE6K42ICUCHLZHDGEZA5CNFSM6AAAAABJGVJ4HOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUA7RQRW.gif> Message ID: ***@***.*** ***@***.***> >
|
macchiati
previously approved these changes
Jun 12, 2024
Fix test failure
macchiati
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17590
Update coverage levels for Microsoft
ALLOW_MANY_COMMITS=true