Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17416 v45 BRS validity #3531

Closed
wants to merge 2 commits into from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Feb 27, 2024

  • also note we are starting to see spdx changes from CLDR-17110

CLDR-17416

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

- also starting to pickup spdx changes from CLDR-17110
@srl295 srl295 self-assigned this Feb 27, 2024
@srl295 srl295 requested a review from a team February 27, 2024 21:18
@macchiati
Copy link
Member

Tests failing

@@ -35,12 +35,12 @@
Vaii Vith
Wara Wcho
Xpeo Xsux
Yezi Yiii Zanb
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's going on with Zanb? @markusicu @macchiati

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been here before.. #3233 (comment)

blocked by CLDR-17056 - I'll back out Zanb for now.

@srl295 srl295 requested a review from macchiati February 28, 2024 00:34
- and add comment linking CLDR-17056 in the xml
@@ -35,7 +35,7 @@
Vaii Vith
Wara Wcho
Xpeo Xsux
Yezi Yiii Zanb
Yezi Yiii Zanb <!-- Note: for Zanb see CLDR-17056 -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ so that we see this the next time the generator is run

@macchiati macchiati mentioned this pull request Feb 28, 2024
1 task
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided it was time to fix the tooling. I figured that rather than have the tooling be a separate PR, it was better to do it all at once. So could you review #3537 and if that's ok, merge it and close this PR?

@srl295 srl295 closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants