Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17088 Flesh out en.xml; new test for null/blank/inheritance-marker #3444

Closed
wants to merge 2 commits into from
Closed

CLDR-17088 Flesh out en.xml; new test for null/blank/inheritance-marker #3444

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01bdfb0
CLDR-17088 Flesh out en.xml; new test for null/blank/inheritance-marker
btangmu Jan 8, 2024
d95d4d2
CLDR-17088 Flesh out en.xml; new test for null/blank/inheritance-marker
btangmu Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions tools/cldr-code/src/test/java/org/unicode/cldr/test/TestEnInheritance.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
package org.unicode.cldr.test;

import static org.junit.jupiter.api.Assertions.assertEquals;

import java.util.logging.Logger;
import org.junit.jupiter.api.Test;
import org.unicode.cldr.util.*;

/**
* Check modern coverage inherited values in en that are marked with up arrows or are blank; all
* values should be explicit in en
*/
public class TestEnInheritance {
private static final Logger logger = Logger.getLogger(TestEnInheritance.class.getName());

private static final String LOCALE_ID = "en";

@Test
void testEn() {
final CLDRConfig config = CLDRConfig.getInstance();
final CLDRFile cldrFile = config.getCLDRFile(LOCALE_ID, false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, you need to check on this. We need to hit not only the main directory, but also the annotations directory. I think Factory getCommonAndSeedAndMainAndAnnotationsFactory() is the safest.

final SupplementalDataInfo sdi = SupplementalDataInfo.getInstance();
final CoverageLevel2 coverageLevel = CoverageLevel2.getInstance(sdi, LOCALE_ID);
int pathsWithNullValue = 0, pathsWithBlankValue = 0, pathsWithMarkerValue = 0;
for (final String path : cldrFile.fullIterable()) {
if (coverageLevel.getLevel(path).getLevel() <= Level.MODERN.getLevel()) {
String value = cldrFile.getStringValue(path);
if (value == null) {
complain("null value", ++pathsWithNullValue, path);
} else if (value.isBlank()
&& !DisplayAndInputProcessor.FSR_START_PATH.equals(path)
&& !DisplayAndInputProcessor.NSR_START_PATH.equals(path)) {
complain("blank value", ++pathsWithBlankValue, path);
} else if (CldrUtility.INHERITANCE_MARKER.equals(value)) {
complain("inheritance marker", ++pathsWithMarkerValue, path);
}
}
}
assertEquals(0, pathsWithNullValue, "null values");
assertEquals(0, pathsWithBlankValue, "blank values");
assertEquals(0, pathsWithMarkerValue, "inheritance marker values");
}

private void complain(String description, int count, String path) {
logger.severe(
this.getClass().getSimpleName() + " -- " + description + " " + count + " " + path);
}
}
Loading