CLDR-17088 Flesh out en.xml; new test for null/blank/inheritance-marker #3444
Conversation
-New TestEnInheritance.java
| @Test | ||
| void testEn() { | ||
| final CLDRConfig config = CLDRConfig.getInstance(); | ||
| final CLDRFile cldrFile = config.getCLDRFile(LOCALE_ID, true); |
There was a problem hiding this comment.
This is getting the resolved value, so the results will not be accurate.
There was a problem hiding this comment.
Second commit changes resolving from true to false
| String value = cldrFile.getStringValue(path); | ||
| if (value == null) { | ||
| complain("null value", ++pathsWithNullValue, path); | ||
| } else if (value.isBlank()) { |
There was a problem hiding this comment.
There are a few values that can be blank, so they would need to be excluded. I can't remember if these are marked in the DTD or not; if not, we might consider that so that they can be tested with DtdData.
There was a problem hiding this comment.
nativeSpaceReplacement and foreignSpaceReplacement and ...?
There was a problem hiding this comment.
The second commit adds exclusions for nativeSpaceReplacement and foreignSpaceReplacement based on their constants DisplayAndInputProcessor.FSR_START_PATH/NSR_START_PATH -- not sure how we'd use the DTD...?
|
Locally this (first commit) results in these errors, and I expect it to have the same errors here: The ticket specifies "blank" values as problematic, but maybe that's not to be taken literally, especially for nativeSpaceReplacement and foreignSpaceReplacement? Also there's a null value for one path, the Gulf time zone. There are no occurrences of INHERITANCE_MARKER (in Modern-coverage paths). |
-New TestEnInheritance.java -Use non-resolving CLDRFile -Allow blank for foreignSpaceReplacement, nativeSpaceReplacement
|
Second commit running locally gets no more "blank" errors, still gets the Gulf time zone "null" error, and gets 155 new "null" errors for currencies including Still no INHERITANCE_MARKER errors |
| @Test | ||
| void testEn() { | ||
| final CLDRConfig config = CLDRConfig.getInstance(); | ||
| final CLDRFile cldrFile = config.getCLDRFile(LOCALE_ID, false); |
There was a problem hiding this comment.
Also, you need to check on this. We need to hit not only the main directory, but also the annotations directory. I think Factory getCommonAndSeedAndMainAndAnnotationsFactory() is the safest.
|
Good. I'm a bit surprised we don't get more of the other items in CODE_FALLBACK besides currency, but that's good news. |
|
See #4110 |
-New TestEnInheritance.java
CLDR-17088
ALLOW_MANY_COMMITS=true