Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17079 Flag interface: fix some bugs #3415

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

btangmu
Copy link
Member

@btangmu btangmu commented Dec 9, 2023

-Never show flag icon on a Discuss button since it cannot cause a path to be flagged

-If a Request button is disabled, do not show a flag icon on it or an empty space for a flag icon

-When a forum post is made, update the locale stamp so the front end will request an update

-New STFactory.PerLocaleData.nextStamp to enable SurveyForum to update the locale stamp

-Improve performance of STFactory.localeStamps initialization, do not copy Set as Array just to get its size

-Remove unused method STFactory.getLocaleStamp

CLDR-17079

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

-Never show flag icon on a Discuss button since it cannot cause a path to be flagged

-If a Request button is disabled, do not show a flag icon on it or an empty space for a flag icon

-When a forum post is made, update the locale stamp so the front end will request an update

-New STFactory.PerLocaleData.nextStamp to enable SurveyForum to update the locale stamp

-Improve performance of STFactory.localeStamps initialization, do not copy Set as Array just to get its size

-Remove unused method STFactory.getLocaleStamp
@btangmu btangmu self-assigned this Dec 9, 2023
@btangmu btangmu merged commit 06a4a2e into unicode-org:main Dec 18, 2023
11 checks passed
@btangmu btangmu deleted the t17079_a branch December 18, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants