CLDR-17079 Flag interface: fix some bugs (#3415)

-Never show flag icon on a Discuss button since it cannot cause a path to be flagged

-If a Request button is disabled, do not show a flag icon on it or an empty space for a flag icon

-When a forum post is made, update the locale stamp so the front end will request an update

-New STFactory.PerLocaleData.nextStamp to enable SurveyForum to update the locale stamp

-Improve performance of STFactory.localeStamps initialization, do not copy Set as Array just to get its size

-Remove unused method STFactory.getLocaleStamp

tools/cldr-apps/js/src/esm/cldrForum.mjs

@@ -872,13 +872,18 @@ function makeOneNewPostButton(
   code,
   value
 ) {
-  const buttonClass = couldFlag
+  // A "new post" button has type cldrForumType.REQUEST or cldrForumType.DISCUSS.
+  // REQUEST is only enabled if there is a non-null value (which the user voted for).
+  const disabled = postType === cldrForumType.REQUEST && value === null;
+  // Only an enabled REQUEST button can really cause a path to be flagged.
+  const reallyCanFlag =
+    couldFlag && postType === cldrForumType.REQUEST && !disabled;
+  const buttonClass = reallyCanFlag
     ? "addPostButton forumNewPostFlagButton btn btn-default btn-sm"
     : "addPostButton forumNewButton btn btn-default btn-sm";
 
   const newButton = forumCreateChunk(label, "button", buttonClass);
-  // a "new post" button has type cldrForumType.REQUEST or cldrForumType.DISCUSS
-  if (postType === cldrForumType.REQUEST && value === null) {
+  if (disabled) {
     newButton.disabled = true;
   } else {
     cldrDom.listenFor(newButton, "click", function (e) {
@@ -892,7 +897,7 @@ function makeOneNewPostButton(
           if (o.result && o.result.ph) {
             subj = xpathMap.formatPathHeader(o.result.ph);
           }
-          if (couldFlag) {
+          if (reallyCanFlag) {
             subj += " (Flag for review)";
           }
           openPostOrReply({

tools/cldr-apps/src/main/java/org/unicode/cldr/web/STFactory.java

@@ -115,6 +115,10 @@ public final class PerLocaleData implements Comparable<PerLocaleData>, BallotBox
         /** Voting information for each XPath */
         private final Map<String, PerXPathData> xpathToData = new HashMap<>();
 
+        public void nextStamp() {
+            stamp.next();
+        }
+
         /** Per-xpath data. There's one of these per xpath- voting data, etc. */
         final class PerXPathData {
             /**
@@ -354,7 +358,7 @@ public Date getLastModDate() {
                         dataBackedSource =
                                 new BallotBoxXMLSource<User>(diskData.cloneAsThawed(), this);
                 loadVoteValues(dataBackedSource, VoteLoadingContext.ORDINARY_LOAD_VOTES);
-                stamp.next();
+                nextStamp();
                 dataBackedSource.addListener(gTestCache);
                 XMLSource resolvedXmlsource = makeResolvingSource();
                 rFile =
@@ -1135,7 +1139,7 @@ private void internalSetVoteForValue(
             makeSureInPathsForFile(distinguishingXpath, user, value);
             getXPathData(distinguishingXpath)
                     .setVoteForValue(user, value, voteOverride, when, voteType);
-            stamp.next();
+            nextStamp();
         }
 
         @Override
@@ -1334,7 +1338,7 @@ public PerLocaleData load(CLDRLocale key) throws Exception {
                             });
 
     private final Map<CLDRLocale, MutableStamp> localeStamps =
-            new ConcurrentHashMap<>(SurveyMain.getLocales().length);
+            new ConcurrentHashMap<>(SurveyMain.getLocalesSet().size());
 
     /**
      * Return changetime.
@@ -1351,16 +1355,6 @@ public MutableStamp mintLocaleStamp(CLDRLocale locale) {
         return s;
     }
 
-    /**
-     * Get the locale stamp, loading the locale if not loaded.
-     *
-     * @param loc
-     * @return
-     */
-    public Stamp getLocaleStamp(CLDRLocale loc) {
-        return get(loc).getStamp();
-    }
-
     /**
      * Fetch a locale from the per locale data, create if not there.
      *

tools/cldr-apps/src/main/java/org/unicode/cldr/web/SurveyForum.java

@@ -1301,6 +1301,8 @@ private Integer doPostInternal(PostInfo postInfo) throws SurveyException {
         if (postInfo.getSendEmail()) {
             emailNotify(postInfo, postId);
         }
+        CLDRLocale locale = postInfo.getLocale();
+        sm.getSTFactory().get(locale).nextStamp();
         return postId;
     }