Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17204 kbd: v44: dtd fix for locales #3369

Merged
merged 1 commit into from
Nov 3, 2023
Merged

CLDR-17204 kbd: v44: dtd fix for locales #3369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion keyboards/dtd/ldmlKeyboard3.dtd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ Please view the subcommittee page for the most recent information.
<!--@TECHPREVIEW-->
<!ATTLIST locale id CDATA #REQUIRED >
<!--@MATCH:validity/bcp47-wellformed-->
<!--@VALUE-->

<!ELEMENT version EMPTY >
<!--@TECHPREVIEW-->
Expand Down
1 change: 0 additions & 1 deletion keyboards/dtd/ldmlKeyboard3.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ Note: DTD @-annotations are not currently converted to .xsd. For full CLDR file
</xs:element>



<xs:element name="version">
<xs:complexType>
<xs:attribute name="number"/>
Expand Down
1 change: 1 addition & 0 deletions tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestDtdData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,6 +766,7 @@ public boolean isDistinguishingOld(DtdType dtdType, String elementName, String a
|| elementName.equals("keyList") && attribute.equals("id")
|| elementName.equals("flick") && attribute.equals("id")
|| elementName.equals("import") && attribute.equals("path")
|| elementName.equals("locale") && attribute.equals("id")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@macchiati CLDR-16616 what value (pardon the pun) does this test add to CLDR?

|| elementName.equals("import") && attribute.equals("base")
|| elementName.equals("layer") && attribute.equals("id")
|| elementName.equals("string") && attribute.equals("id")
Expand Down
Loading