CLDR-17204 kbd: v44: dtd fix for locales #3369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miloush
previously approved these changes
Oct 27, 2023
|
needs a code fix
|
- the <locale id> attribute was set as @value which caused it to be wrongly flagged as a duplicate.
srl295
force-pushed
the
kbd/cldr-17204/locales-dtd
branch
from
6b90580 to
f62e5f5
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
srl295
commented
Nov 3, 2023
| @@ -766,6 +766,7 @@ public boolean isDistinguishingOld(DtdType dtdType, String elementName, String a | |||
| || elementName.equals("keyList") && attribute.equals("id") | |||
| || elementName.equals("flick") && attribute.equals("id") | |||
| || elementName.equals("import") && attribute.equals("path") | |||
| || elementName.equals("locale") && attribute.equals("id") | |||
There was a problem hiding this comment.
@macchiati CLDR-16616 what value (pardon the pun) does this test add to CLDR?
srl295
changed the title
srl295
changed the title
pedberg-icu
approved these changes
Nov 3, 2023
srl295
added a commit
to srl295/cldr
that referenced
this pull request
Nov 3, 2023
- cherry-pick from maint-44: CLDR-17204 kbd: dtd fix for locales (unicode-org#3369) - the <locale id> attribute was set as @value which caused it to be wrongly flagged as a duplicate. (cherry picked from commit b07c9d8)
1 task
srl295
added a commit
to srl295/cldr
that referenced
this pull request
Nov 3, 2023
- cherry-pick from maint-44: CLDR-17204 kbd: dtd fix for locales (unicode-org#3369) - the <locale id> attribute was set as @value which caused it to be wrongly flagged as a duplicate. (cherry picked from commit b07c9d8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<locale id=…>attribute was set as@VALUEwhich caused it to be wrongly flagged as a duplicate.CLDR-17204
ALLOW_MANY_COMMITS=true