Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-17141 kbd: drop transform=no #3330

Merged
merged 1 commit into from
Oct 11, 2023
Merged

CLDR-17141 kbd: drop transform=no #3330

merged 1 commit into from
Oct 11, 2023

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Oct 10, 2023 •
edited
Loading

fyi @jahorton

  • expand documentation about use of markers to inhibit transforms

CLDR-17141

  • This PR completes the ticket.

also see #3332 which is a sub-PR of this

ALLOW_MANY_COMMITS=true

@srl295 srl295 requested review from mcdurdin, miloush and a team October 10, 2023 14:26
@srl295 srl295 self-assigned this Oct 10, 2023
@srl295
Copy link
Member Author

srl295 commented Oct 10, 2023

Ticket not accepted yet ,but fyi

@srl295 srl295 force-pushed the srl295/kbd/cldr-17141-drop-transform-no branch from f7efe77 to 6ee3b50 Compare October 10, 2023 19:52
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • docs/ldml/tr35-keyboards.md is different
  • keyboards/dtd/ldmlKeyboard3.dtd is different
  • keyboards/dtd/ldmlKeyboard3.xsd is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295
Copy link
Member Author

srl295 commented Oct 11, 2023

also see #3332 which is a sub-PR of this

Base automatically changed from srl295/kbd/cldr-17113-naming to main October 11, 2023 21:02
@srl295 srl295 force-pushed the srl295/kbd/cldr-17141-drop-transform-no branch from 6ee3b50 to 00b938b Compare October 11, 2023 21:04
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • common/supplemental/attributeValueValidity.xml is no longer changed in the branch
  • docs/ldml/tr35-keyboards.md is different
  • keyboards/3.0/fr-t-k0-azerty.xml is no longer changed in the branch
  • keyboards/3.0/ja-Latn.xml is no longer changed in the branch
  • keyboards/3.0/mt-t-k0-47key.xml is no longer changed in the branch
  • keyboards/3.0/mt.xml is no longer changed in the branch
  • keyboards/3.0/pcm.xml is no longer changed in the branch
  • keyboards/3.0/pt-t-k0-abnt2.xml is no longer changed in the branch
  • keyboards/import/keys-Latn-implied.xml is no longer changed in the branch
  • keyboards/import/keys-Zyyy-currency.xml is no longer changed in the branch
  • keyboards/import/keys-Zyyy-punctuation.xml is no longer changed in the branch
  • tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestDtdData.java is no longer changed in the branch
  • tools/cldr-code/src/test/resources/org/unicode/cldr/tool/KeyboardFlatten/broken-import-missing.xml is no longer changed in the branch
  • tools/cldr-code/src/test/resources/org/unicode/cldr/tool/KeyboardFlatten/broken-import-unknownbase.xml is no longer changed in the branch
  • tools/cldr-code/src/test/resources/org/unicode/cldr/tool/KeyboardFlatten/broken-import-unknownver.xml is no longer changed in the branch
  • tools/cldr-code/src/test/resources/org/unicode/cldr/tool/KeyboardFlatten/broken-import-wrongparent.xml is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 srl295 mentioned this pull request Oct 11, 2023
Merged
@srl295
Copy link
Member Author

srl295 commented Oct 11, 2023

closed per ticket comments

@srl295 srl295 closed this Oct 11, 2023
@srl295 srl295 deleted the srl295/kbd/cldr-17141-drop-transform-no branch October 11, 2023 21:32
@srl295 srl295 restored the srl295/kbd/cldr-17141-drop-transform-no branch October 11, 2023 21:54
@srl295 srl295 reopened this Oct 11, 2023
@srl295
CLDR-17141 kbd: drop transform=no
7571d78 
- expand documentation about use of markers to inhibit transforms
@srl295 srl295 force-pushed the srl295/kbd/cldr-17141-drop-transform-no branch from 0ebdc9e to 7571d78 Compare October 11, 2023 21:59
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • docs/ldml/tr35-keyboards.md is different
  • keyboards/dtd/ldmlKeyboard3.dtd is now changed in the branch
  • keyboards/dtd/ldmlKeyboard3.xsd is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 srl295 requested a review from a team October 11, 2023 22:00
@srl295
Copy link
Member Author

srl295 commented Oct 11, 2023

@miloush OK, are you OK with merging this which actually does drop transform=no

@srl295
Copy link
Member Author

srl295 commented Oct 11, 2023

Oh sorry I meant yes, feel free to drop.

@srl295 srl295 mentioned this pull request Oct 11, 2023
Merged
1 task
@srl295 srl295 merged commit 1a52361 into main Oct 11, 2023
@srl295 srl295 deleted the srl295/kbd/cldr-17141-drop-transform-no branch October 11, 2023 22:47
srl295 added a commit to srl295/cldr that referenced this pull request Oct 11, 2023
@srl295
CLDR-15034: cherry-pick CLDR-17141 kbd: drop transform=no (unicode-or…
1ca85df 
…g#3330)

- expand documentation about use of markers to inhibit transforms

(cherry picked from commit 1a52361)
srl295 added a commit to srl295/cldr that referenced this pull request Oct 11, 2023
@srl295
CLDR-15034 cherry-pick CLDR-17141 kbd: drop transform=no (unicode-org…
9e7fa41 
…#3330)

- expand documentation about use of markers to inhibit transforms

(cherry picked from commit 1a52361)
@srl295 srl295 mentioned this pull request Oct 11, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahorton jahorton jahorton approved these changes

@miloush miloush miloush approved these changes

@mcdurdin mcdurdin Awaiting requested review from mcdurdin

Assignees

@srl295 srl295

Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srl295 @miloush @jahorton